Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227373004: Make Sky example game run offline (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
viktorl, eseidel1
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, viktorl, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -284 lines) Patch
M sky/sdk/example/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/example/demo_launcher/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/demo_launcher/apk/org/domokit/sky/demo/SkyDemoApplication.java View 1 chunk +1 line, -0 lines 0 comments Download
M sky/sdk/example/demo_launcher/lib/main.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + sky/sdk/example/game/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + sky/sdk/example/game/apk/AndroidManifest.xml View 1 chunk +2 lines, -2 lines 0 comments Download
A + sky/sdk/example/game/assets/nebula.png View Binary file 0 comments Download
A + sky/sdk/example/game/assets/sprites.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/game/assets/sprites.png View Binary file 0 comments Download
A + sky/sdk/example/game/assets/starfield.png View Binary file 0 comments Download
M sky/sdk/example/game/lib/game_demo_world.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/sdk/example/game/lib/image_map.dart View 1 chunk +13 lines, -25 lines 0 comments Download
M sky/sdk/example/game/lib/sprites.dart View 1 chunk +6 lines, -1 line 0 comments Download
M sky/sdk/example/game/main.dart View 2 chunks +24 lines, -22 lines 0 comments Download
D sky/sdk/example/game/res/nebula.png View Binary file 0 comments Download
D sky/sdk/example/game/res/sprites.json View 1 chunk +0 lines, -219 lines 0 comments Download
D sky/sdk/example/game/res/sprites.png View Binary file 0 comments Download
D sky/sdk/example/game/res/starfield.png View Binary file 0 comments Download
A sky/sdk/example/game/sky.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
M sky/sdk/lib/mojo/asset_bundle.dart View 5 chunks +24 lines, -8 lines 2 comments Download
M sky/sdk/lib/mojo/net/fetch.dart View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-10 16:02:35 UTC) #1
viktorl
lgtm https://codereview.chromium.org/1227373004/diff/1/sky/sdk/lib/mojo/asset_bundle.dart File sky/sdk/lib/mojo/asset_bundle.dart (right): https://codereview.chromium.org/1227373004/diff/1/sky/sdk/lib/mojo/asset_bundle.dart#newcode34 sky/sdk/lib/mojo/asset_bundle.dart:34: Future<String> loadString(String key) { It may be worth ...
5 years, 5 months ago (2015-07-10 16:39:37 UTC) #3
abarth-chromium
https://codereview.chromium.org/1227373004/diff/1/sky/sdk/lib/mojo/asset_bundle.dart File sky/sdk/lib/mojo/asset_bundle.dart (right): https://codereview.chromium.org/1227373004/diff/1/sky/sdk/lib/mojo/asset_bundle.dart#newcode34 sky/sdk/lib/mojo/asset_bundle.dart:34: Future<String> loadString(String key) { On 2015/07/10 at 16:39:37, viktorl ...
5 years, 5 months ago (2015-07-10 16:42:28 UTC) #4
abarth-chromium
5 years, 5 months ago (2015-07-10 16:49:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0d84c49b97f8c73950faa086d4f5aa0693e18241 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698