Roll mojo SDK to 734c6e1652ff2f3b696e441722838f453f4f9b42

mojo/services/network/cookie_store_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_SERVICES_NETWORK_COOKIE_STORE_IMPL_H_
 #define MOJO_SERVICES_NETWORK_COOKIE_STORE_IMPL_H_
 
 #include "mojo/services/network/public/interfaces/cookie_store.mojom.h"
+#include "third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h"
 #include "url/gurl.h"
 
 namespace mojo {
 class NetworkContext;
 
-class CookieStoreImpl : public InterfaceImpl<CookieStore> {
+class CookieStoreImpl : public CookieStore {
  public:
-  CookieStoreImpl(NetworkContext* context, const GURL& origin);
+  CookieStoreImpl(InterfaceRequest<CookieStore> request,
+                  NetworkContext* context,
+                  const GURL& origin);
   ~CookieStoreImpl() override;
 
  private:
   // CookieStore methods:
   void Get(const String& url, const Callback<void(String)>& callback) override;
   void Set(const String& url,
            const String& cookie,
            const Callback<void(bool)>& callback) override;
 
   NetworkContext* context_;
   GURL origin_;
+  mojo::StrongBinding<CookieStore> binding_;

[viettrungluu, 2015/07/09 16:41:52]

Here and elsewhere: I have a slight preference for having binding_ be declared
first, basically matching the order of the arguments to the constructor
(logically, the request "gets turned into" a binding).

[qsr, 2015/07/10 07:53:17]

Done. But I personally have a preference for the other way around. My reasoning
is that a bound Binding has a reference to the object, and if something makes it
do a call, it should not happen with an partially destructed object. Now, I
agree that this should not happen, but having it destroyed first ensure it will
not.

 
   DISALLOW_COPY_AND_ASSIGN(CookieStoreImpl);
 };
 
 }  // namespace mojo
 
 #endif  // MOJO_SERVICES_NETWORK_COOKIE_STORE_IMPL_H_