Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1227363005: mac: Include <IOSurface/IOSurface.h> instead of <IOSurface/IOSurfaceAPI.h> (Closed)

Created:
5 years, 5 months ago by dshwang
Modified:
5 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Include <IOSurface/IOSurface.h> instead of <IOSurface/IOSurfaceAPI.h> Mac Developer Library [1] notes "In general, you should not include this header directly. Instead, include <IOSurface/IOSurface.h>." [1] https://developer.apple.com/library/mac/documentation/Miscellaneous/Reference/IOSurfaceAPI_header_reference/#//apple_ref/c/tdef/IOSurfaceRef Committed: https://crrev.com/961aa9d0f3604c637d1424b386334c6575af42cd Cr-Commit-Position: refs/heads/master@{#339728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_io_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/mac/io_surface_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/accelerated_widget_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/accelerated_widget_mac/io_surface_texture.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/surface/accelerated_surface_mac.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (4 generated)
dshwang
hi sievers, could you review?
5 years, 5 months ago (2015-07-20 10:27:19 UTC) #2
no sievers
+ccameron
5 years, 5 months ago (2015-07-20 17:11:43 UTC) #4
ccameron
Seems reasonable. If it builds, lgtm.
5 years, 5 months ago (2015-07-20 17:20:27 UTC) #5
dshwang
thx for reviewing. sievers, could you review gpu/ and ui/gl? stuartmorgan, could you review ui/surface?
5 years, 5 months ago (2015-07-20 17:27:11 UTC) #7
stuartmorgan
What problem are you trying to solve here?
5 years, 5 months ago (2015-07-20 17:30:05 UTC) #8
dshwang
On 2015/07/20 17:30:05, stuartmorgan wrote: > What problem are you trying to solve here? there ...
5 years, 5 months ago (2015-07-20 17:35:43 UTC) #9
stuartmorgan
ui/surface/ LGTM I guess, but this seems like low-value churn if there's nothing but a ...
5 years, 5 months ago (2015-07-20 18:08:14 UTC) #10
dshwang
On 2015/07/20 18:08:14, stuartmorgan wrote: > ui/surface/ LGTM I guess, but this seems like low-value ...
5 years, 5 months ago (2015-07-21 10:02:26 UTC) #11
no sievers
On 2015/07/21 10:02:26, dshwang wrote: > On 2015/07/20 18:08:14, stuartmorgan wrote: > > ui/surface/ LGTM ...
5 years, 5 months ago (2015-07-21 18:38:42 UTC) #12
dshwang
On 2015/07/21 18:38:42, sievers wrote: > On 2015/07/21 10:02:26, dshwang wrote: > > On 2015/07/20 ...
5 years, 5 months ago (2015-07-21 18:52:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227363005/1
5 years, 5 months ago (2015-07-21 18:53:23 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 20:12:21 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 20:13:29 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/961aa9d0f3604c637d1424b386334c6575af42cd
Cr-Commit-Position: refs/heads/master@{#339728}

Powered by Google App Engine
This is Rietveld 408576698