Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: content/browser/background_sync/background_sync_manager.h

Issue 1227363002: [Background Sync] Gather UMA data for Background Sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Record whether a registration could fire immediately or not Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_sync/background_sync_manager.h
diff --git a/content/browser/background_sync/background_sync_manager.h b/content/browser/background_sync/background_sync_manager.h
index e49c815894fcd003337c2519fdfa23313a6077ed..8cd117b6fe3c401e372df1b285c8b69fa5661532 100644
--- a/content/browser/background_sync/background_sync_manager.h
+++ b/content/browser/background_sync/background_sync_manager.h
@@ -207,11 +207,12 @@ class CONTENT_EXPORT BackgroundSyncManager
int64 sw_registration_id,
const RegistrationKey& registration_key,
BackgroundSyncRegistration::RegistrationId sync_registration_id,
+ SyncPeriodicity periodicity,
const StatusCallback& callback);
- void UnregisterDidStore(
- int64 sw_registration_id,
- const StatusCallback& callback,
- ServiceWorkerStatusCode status);
+ void UnregisterDidStore(int64 sw_registration_id,
+ SyncPeriodicity periodicity,
+ const StatusCallback& callback,
+ ServiceWorkerStatusCode status);
// GetRegistration callbacks
void GetRegistrationImpl(int64 sw_registration_id,
@@ -223,6 +224,8 @@ class CONTENT_EXPORT BackgroundSyncManager
SyncPeriodicity periodicity,
const StatusAndRegistrationsCallback& callback);
+ bool WouldFireRegistrationWithOptions(
+ const BackgroundSyncRegistrationOptions& options);
bool IsRegistrationReadyToFire(
const BackgroundSyncRegistration& registration);
@@ -261,6 +264,10 @@ class CONTENT_EXPORT BackgroundSyncManager
const base::Closure& callback,
ServiceWorkerStatusCode status_code);
+ // Called when all sync events have completed.
+ static void OnAllSyncEventsCompleted(const base::TimeTicks& startTime,
Alexei Svitkine (slow) 2015/07/09 21:02:57 Nit: hacker_style not camelCase for param names
iclelland 2015/07/10 14:57:26 Done.
+ const base::Closure& callback);
+
// OnRegistrationDeleted callbacks
void OnRegistrationDeletedImpl(int64 registration_id,
const base::Closure& callback);

Powered by Google App Engine
This is Rietveld 408576698