[Background Sync] Gather UMA data for Background Sync

content/browser/background_sync/background_sync_metrics.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/background_sync/background_sync_metrics.h"
+
+#include "base/metrics/histogram_macros.h"
+#include "base/metrics/user_metrics_action.h"
+
+namespace content {
+
+void BackgroundSyncMetrics::RecordEventResult(SyncPeriodicity periodicity,
+                                              bool success) {
+  switch (periodicity) {
+    case SYNC_ONE_SHOT:
+      UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Event.OneShotResult", success);
+      return;
+    case SYNC_PERIODIC:
+      UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Event.PeriodicResult", success);
+      return;
+  }
+  NOTREACHED();
+}
+
+void BackgroundSyncMetrics::RecordSyncEventHandlingTime(
+    const base::TimeDelta& time) {
+  // The total event handling time should be under 5 minutes; we'll record up to
+  // 6 minutes, to be safe.
+  UMA_HISTOGRAM_CUSTOM_TIMES("BackgroundSync.Event.Time", time,
+                             base::TimeDelta::FromMilliseconds(10),
+                             base::TimeDelta::FromMinutes(6), 50);
+}
+
+void BackgroundSyncMetrics::CountRegistration(
+    SyncPeriodicity periodicity,
+    RegistrationCouldFire registration_could_fire,
+    RegistrationIsDuplicate registration_is_duplicate,
+    BackgroundSyncManager::ErrorType result) {
+  switch (periodicity) {
+    case SYNC_ONE_SHOT:
+      UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Registration.OneShot", result,
+                                BackgroundSyncManager::ERROR_TYPE_MAX + 1);
+      UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Registration.OneShot.CouldFire",
+                            registration_could_fire == REGISTRATION_COULD_FIRE);
+      UMA_HISTOGRAM_BOOLEAN(
+          "BackgroundSync.Registration.OneShot.IsDuplicate",
+          registration_is_duplicate == REGISTRATION_IS_DUPLICATE);
+      return;
+    case SYNC_PERIODIC:
+      UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Registration.Periodic", result,
+                                BackgroundSyncManager::ERROR_TYPE_MAX + 1);
+      UMA_HISTOGRAM_BOOLEAN("BackgroundSync.Registration.Periodic.CouldFire",

[jkarlin, 2015/07/15 17:17:06]

Not sure what periodic could fire means.

[iclelland, 2015/07/15 18:01:35]

I suppose it would have to mean "the power and network were sufficient for this
task to happen immediately, and also, the app chose to register a periodic task
to do it in the future."

If it's not a useful metric (and I'm by no means convinced that it is) then I
can remove it.

[jkarlin, 2015/07/15 19:27:33]

Let's remove this one for now. Easy to add back later if necessary.

[iclelland, 2015/07/16 13:29:44]

Done.

+                            registration_could_fire == REGISTRATION_COULD_FIRE);
+      UMA_HISTOGRAM_BOOLEAN(
+          "BackgroundSync.Registration.Periodic.IsDuplicate",
+          registration_is_duplicate == REGISTRATION_IS_DUPLICATE);
+      return;
+  }
+  NOTREACHED();
+}
+
+void BackgroundSyncMetrics::CountUnregistration(

[jkarlin, 2015/07/15 17:17:06]

Is unregistration a word? Perhaps CountUnregister and CountRegister?

[iclelland, 2015/07/15 18:01:35]

Deregisration? Disregistration? :)

Switched to CountUnregister and CountRegister.
Done.

+    SyncPeriodicity periodicity,
+    BackgroundSyncManager::ErrorType result) {
+  switch (periodicity) {
+    case SYNC_ONE_SHOT:
+      UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Unregistration.OneShot", result,
+                                BackgroundSyncManager::ERROR_TYPE_MAX + 1);
+      return;
+    case SYNC_PERIODIC:
+      UMA_HISTOGRAM_ENUMERATION("BackgroundSync.Unregistration.Periodic",
+                                result,
+                                BackgroundSyncManager::ERROR_TYPE_MAX + 1);
+      return;
+  }
+  NOTREACHED();
+}
+
+}  // namespace content