Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1227303002: Set listener task runner before connect channel. (Closed)

Created:
5 years, 5 months ago by leonhsl(Using Gerrit)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set listener task runner before connect channel. Renderer main thread will run ChannelProxy::SetListenerTaskRunner() to set listener task runner, but the task runner may be accessed on IPC thread at the same time. This CL is to fix the race condition. TBR=nasko@chromium.org BUG=479684 Committed: https://crrev.com/2c0f9f1c87c48b03dc4ef3582f724fcfff389a52 Cr-Commit-Position: refs/heads/master@{#338425}

Patch Set 1 #

Patch Set 2 : Add change for browser_tests #

Patch Set 3 : Update commit msg only. #

Patch Set 4 : Fix trybot error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -11 lines) Patch
M content/child/child_thread_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M content/renderer/in_process_renderer_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +26 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 2 3 3 chunks +7 lines, -2 lines 0 comments Download
M content/renderer/renderer_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
leonhsl(Using Gerrit)
PTAL, Thanks in advance~
5 years, 5 months ago (2015-07-09 09:05:47 UTC) #1
leonhsl(Using Gerrit)
Added change for browser_tests.
5 years, 5 months ago (2015-07-10 03:38:45 UTC) #3
nasko
Hey Avi, Can you take this one? Thanks in advance!
5 years, 5 months ago (2015-07-10 09:06:06 UTC) #5
Avi (use Gerrit)
lgtm
5 years, 5 months ago (2015-07-10 15:44:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227303002/40001
5 years, 5 months ago (2015-07-10 16:12:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/108322) (exceeded global retry quota)
5 years, 5 months ago (2015-07-10 16:25:58 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227303002/50008
5 years, 5 months ago (2015-07-10 16:33:45 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-10 17:24:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227303002/50008
5 years, 5 months ago (2015-07-11 01:57:04 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:50008)
5 years, 5 months ago (2015-07-11 02:01:26 UTC) #18
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 02:02:24 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2c0f9f1c87c48b03dc4ef3582f724fcfff389a52
Cr-Commit-Position: refs/heads/master@{#338425}

Powered by Google App Engine
This is Rietveld 408576698