Add support for V8PerContextData to the leak detector (Chromium side)

content/shell/renderer/layout_test/leak_detector.cc

Index: content/shell/renderer/layout_test/leak_detector.cc
diff --git a/content/shell/renderer/layout_test/leak_detector.cc b/content/shell/renderer/layout_test/leak_detector.cc
index a057563f82a3cc8d2dc220724e21caab4766ebd1..60bca419437d9f284ea1c5564e71ea6f2dd209a7 100644
--- a/content/shell/renderer/layout_test/leak_detector.cc
+++ b/content/shell/renderer/layout_test/leak_detector.cc
@@ -28,6 +28,7 @@ const int kInitialNumberOfLiveRenderObjects = 3;
 const int kInitialNumberOfLiveResources = 0;
 const int kInitialNumberOfScriptPromises = 0;
 const int kInitialNumberOfLiveFrames = 1;
+const int kInitialNumberOfV8PerContextData = 1;
 
 // In the initial state, there are two ActiveDOMObjects (FontFaceSet created by
 // HTMLDocument and SuspendableTimer created by DocumentLoader).
@@ -46,6 +47,8 @@ LeakDetector::LeakDetector(BlinkTestRunner* test_runner)
     kInitialNumberOfLiveActiveDOMObject;
   previous_result_.numberOfLiveScriptPromises = kInitialNumberOfScriptPromises;
   previous_result_.numberOfLiveFrames = kInitialNumberOfLiveFrames;
+  previous_result_.numberOfLiveV8PerContextData =
+    kInitialNumberOfV8PerContextData;
 }
 
 LeakDetector::~LeakDetector() {
@@ -112,6 +115,13 @@ void LeakDetector::onLeakDetectionComplete(
     list->AppendInteger(result.numberOfLiveFrames);
     detail.Set("numberOfLiveFrames", list);
   }
+  if (previous_result_.numberOfLiveFrames <

[haraken, 2015/07/09 14:25:07]

numberOfLiveFrames => numberOfLiveV8ContextData

[hajimehoshi, 2015/07/09 14:27:36]

Ooops!

[hajimehoshi, 2015/07/10 04:27:55]

Done. Fortunately, the tests I added to LeakExpectations are still leaking
V8PerContextData since kInitialNumberOfLiveFrames ==
kInitialNumberOfV8PerContextData.

+      result.numberOfLiveV8PerContextData) {
+    base::ListValue* list = new base::ListValue();
+    list->AppendInteger(previous_result_.numberOfLiveV8PerContextData);
+    list->AppendInteger(result.numberOfLiveV8PerContextData);
+    detail.Set("numberOfLiveV8PerContextData", list);
+  }
 
   if (!detail.empty()) {
     std::string detail_str;