Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227293002: Add support for V8PerContextData to the leak detector (Chromium side) (Closed)

Created:
5 years, 5 months ago by hajimehoshi
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for V8PerContextData to the leak detector (Chromium side) BUG=506466 Committed: https://crrev.com/d42889818998d4428a2f1c045ba0279edfa08723 Cr-Commit-Position: refs/heads/master@{#338279}

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : haraken's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/shell/renderer/layout_test/leak_detector.cc View 1 2 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hajimehoshi
PTAL
5 years, 5 months ago (2015-07-09 14:00:43 UTC) #2
haraken
LGTM https://codereview.chromium.org/1227293002/diff/20001/content/shell/renderer/layout_test/leak_detector.cc File content/shell/renderer/layout_test/leak_detector.cc (right): https://codereview.chromium.org/1227293002/diff/20001/content/shell/renderer/layout_test/leak_detector.cc#newcode118 content/shell/renderer/layout_test/leak_detector.cc:118: if (previous_result_.numberOfLiveFrames < numberOfLiveFrames => numberOfLiveV8ContextData
5 years, 5 months ago (2015-07-09 14:25:07 UTC) #3
hajimehoshi
https://codereview.chromium.org/1227293002/diff/20001/content/shell/renderer/layout_test/leak_detector.cc File content/shell/renderer/layout_test/leak_detector.cc (right): https://codereview.chromium.org/1227293002/diff/20001/content/shell/renderer/layout_test/leak_detector.cc#newcode118 content/shell/renderer/layout_test/leak_detector.cc:118: if (previous_result_.numberOfLiveFrames < On 2015/07/09 14:25:07, haraken wrote: > ...
5 years, 5 months ago (2015-07-09 14:27:36 UTC) #4
hajimehoshi
https://codereview.chromium.org/1227293002/diff/20001/content/shell/renderer/layout_test/leak_detector.cc File content/shell/renderer/layout_test/leak_detector.cc (right): https://codereview.chromium.org/1227293002/diff/20001/content/shell/renderer/layout_test/leak_detector.cc#newcode118 content/shell/renderer/layout_test/leak_detector.cc:118: if (previous_result_.numberOfLiveFrames < On 2015/07/09 14:27:36, hajimehoshi wrote: > ...
5 years, 5 months ago (2015-07-10 04:27:55 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-10 09:08:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227293002/40001
5 years, 5 months ago (2015-07-10 11:56:56 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-10 12:00:50 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 12:01:49 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d42889818998d4428a2f1c045ba0279edfa08723
Cr-Commit-Position: refs/heads/master@{#338279}

Powered by Google App Engine
This is Rietveld 408576698