Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1227233002: Mac: Don't draw a cc::Surface while suspended (Closed)

Created:
5 years, 5 months ago by ccameron
Modified:
5 years, 5 months ago
Reviewers:
jbauman
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, brianderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Don't draw a cc::Surface while suspended It is possible that, when closing a tab on Mac, the RWHVMac that is being closed will have requested that the ui::Compositor draw, and that draw will have not happened yet. The draw will happen after the RWHVMac and its renderer have been destroyed which is wasteful in that the draw is unwanted and buggy in that the resources needed by the draw are destroyed. To avoid this, ensure that the cc::Surface does not draw if the output surface is suspended. BUG=508287 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/cf9b1d9389e1b5052691df0a1521f18af9ca3579 Cr-Commit-Position: refs/heads/master@{#338131}

Patch Set 1 #

Patch Set 2 : fix other platform compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M cc/output/output_surface.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/output/output_surface.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/surfaces/display.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ccameron
This either regressed when the ui::Compositor was moved to use the cc::Scheduler or when it ...
5 years, 5 months ago (2015-07-09 01:22:54 UTC) #2
jbauman
lgtm
5 years, 5 months ago (2015-07-09 01:54:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227233002/1
5 years, 5 months ago (2015-07-09 19:14:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/107916) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-09 19:32:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227233002/20001
5 years, 5 months ago (2015-07-09 20:02:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-09 20:43:23 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 20:44:08 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf9b1d9389e1b5052691df0a1521f18af9ca3579
Cr-Commit-Position: refs/heads/master@{#338131}

Powered by Google App Engine
This is Rietveld 408576698