Switch controlled settings indicators to inlined SVGs.

Switch controlled settings indicators to inlined SVGs.

The names of the .svgs are taken from the official icon name.

Most of the svgs are identical to the old pngs, but the "policy", "extension", and "group" ones are slightly different.

BUG=505953
TBR=oshima@chromium.org,benwells@chromium.org

Committed: https://crrev.com/54f65627c6129366504faf41650f5e61855a485d
Cr-Commit-Position: refs/heads/master@{#338974}

[Evan Stade, 2015-07-09 21:51:42]

estade@chromium.org changed reviewers:
+ bauerb@chromium.org

[Evan Stade, 2015-07-09 21:52:38]

+bauerb for review (if there's a better reviewer, please forward)

Do you know which designer I should ping to double check that the (minor) icon
changes are OK?

[Bernhard Bauer, 2015-07-10 10:46:36]

bauerb@chromium.org changed reviewers:
+ rachelis@google.com

[Bernhard Bauer, 2015-07-10 10:46:37]

+Rachel for supervised user and child account icons.

Not sure who does the design for enterprise, but maybe Rachel knows?

https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_context_menu_model.cc:315:
IDR_OMNIBOX_HTTPS_POLICY_WARNING));
This seems a bit strange, and somewhat brittle, e.g. if the omnibox icon is
changed in the future.

If this is just about using the same warning icon, should we rename the icon
name to reflect that?

[chromium-reviews, 2015-07-10 12:44:12]

Thanks for looping me in Bernhard.

I don't think that we have a dedicated enterprise designer. I'm having
trouble wrapping my head around exactly what this is. Can you provide some
context?

On Fri, Jul 10, 2015 at 12:46 PM, <bauerb@chromium.org> wrote:

> +Rachel for supervised user and child account icons.
>
> Not sure who does the design for enterprise, but maybe Rachel knows?
>
>
>
>
https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
> File chrome/browser/extensions/extension_context_menu_model.cc (right):
>
>
>
https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
> chrome/browser/extensions/extension_context_menu_model.cc:315:
> IDR_OMNIBOX_HTTPS_POLICY_WARNING));
> This seems a bit strange, and somewhat brittle, e.g. if the omnibox icon
> is changed in the future.
>
> If this is just about using the same warning icon, should we rename the
> icon name to reflect that?
>
> https://codereview.chromium.org/1227223004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Bernhard Bauer, 2015-07-10 12:55:29]

Replacing rasterized icons with vector-based ones (out of the Material
Icons set).

On Fri, Jul 10, 2015 at 1:44 PM Rachel Ilan Simpson <rachelis@google.com>
wrote:

> Thanks for looping me in Bernhard.
>
> I don't think that we have a dedicated enterprise designer. I'm having
> trouble wrapping my head around exactly what this is. Can you provide some
> context?
>
> On Fri, Jul 10, 2015 at 12:46 PM, <bauerb@chromium.org> wrote:
>
>> +Rachel for supervised user and child account icons.
>>
>> Not sure who does the design for enterprise, but maybe Rachel knows?
>>
>>
>>
>>
https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
>> File chrome/browser/extensions/extension_context_menu_model.cc (right):
>>
>>
>>
https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
>> chrome/browser/extensions/extension_context_menu_model.cc:315:
>> IDR_OMNIBOX_HTTPS_POLICY_WARNING));
>> This seems a bit strange, and somewhat brittle, e.g. if the omnibox icon
>> is changed in the future.
>>
>> If this is just about using the same warning icon, should we rename the
>> icon name to reflect that?
>>
>> https://codereview.chromium.org/1227223004/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2015-07-10 15:15:12]

Where exactly?

On Fri, Jul 10, 2015 at 2:55 PM, Bernhard Bauer <bauerb@chromium.org> wrote:

> Replacing rasterized icons with vector-based ones (out of the Material
> Icons set).
>
> On Fri, Jul 10, 2015 at 1:44 PM Rachel Ilan Simpson <rachelis@google.com>
> wrote:
>
>> Thanks for looping me in Bernhard.
>>
>> I don't think that we have a dedicated enterprise designer. I'm having
>> trouble wrapping my head around exactly what this is. Can you provide some
>> context?
>>
>> On Fri, Jul 10, 2015 at 12:46 PM, <bauerb@chromium.org> wrote:
>>
>>> +Rachel for supervised user and child account icons.
>>>
>>> Not sure who does the design for enterprise, but maybe Rachel knows?
>>>
>>>
>>>
>>>
https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
>>> File chrome/browser/extensions/extension_context_menu_model.cc (right):
>>>
>>>
>>>
https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
>>> chrome/browser/extensions/extension_context_menu_model.cc:315:
>>> IDR_OMNIBOX_HTTPS_POLICY_WARNING));
>>> This seems a bit strange, and somewhat brittle, e.g. if the omnibox icon
>>> is changed in the future.
>>>
>>> If this is just about using the same warning icon, should we rename the
>>> icon name to reflect that?
>>>
>>> https://codereview.chromium.org/1227223004/
>>>
>>
>>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Evan Stade, 2015-07-10 19:04:16]

On 2015/07/10 15:15:12, chromium-reviews wrote:
> Where exactly?

The icons are being replaced in both WebUI and native code (you can look at the
linked bug for some previous CLs to this end). In this CL, the icons in question
are the indicators next to settings in chrome://settings which are controlled by
policy, supervisor, etc. The icons come from go/icons.

https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_context_menu_model.cc:315:
IDR_OMNIBOX_HTTPS_POLICY_WARNING));
On 2015/07/10 10:46:37, Bernhard Bauer wrote:
> This seems a bit strange, and somewhat brittle, e.g. if the omnibox icon is
> changed in the future.
> 
> If this is just about using the same warning icon, should we rename the icon
> name to reflect that?

We probably want this to change if the omnibox icon changes (to maintain
consistency). My thinking was that this was no more brittle than it used to be
because if the icons were changed in chrome://settings this one would also
magically change, for better or worse. If you prefer I guess I can leave the old
identifier and use it here, as it doesn't change the size of the pak file either
way.

[Bernhard Bauer, 2015-07-10 20:27:31]

lgtm

https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_context_menu_model.cc:315:
IDR_OMNIBOX_HTTPS_POLICY_WARNING));
On 2015/07/10 19:04:16, Evan Stade wrote:
> On 2015/07/10 10:46:37, Bernhard Bauer wrote:
> > This seems a bit strange, and somewhat brittle, e.g. if the omnibox icon is
> > changed in the future.
> > 
> > If this is just about using the same warning icon, should we rename the icon
> > name to reflect that?
> 
> We probably want this to change if the omnibox icon changes (to maintain
> consistency). My thinking was that this was no more brittle than it used to be
> because if the icons were changed in chrome://settings this one would also
> magically change, for better or worse. If you prefer I guess I can leave the
old
> identifier and use it here, as it doesn't change the size of the pak file
either
> way.

Oh, I didn't realize this is actually a policy-related icon for the omnibox, not
a generic warning. In which case, either is fine with me.

[Evan Stade, 2015-07-13 23:44:42]

On 2015/07/10 20:27:31, Bernhard Bauer wrote:
> lgtm
> 
>
https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
> File chrome/browser/extensions/extension_context_menu_model.cc (right):
> 
>
https://codereview.chromium.org/1227223004/diff/20001/chrome/browser/extensio...
> chrome/browser/extensions/extension_context_menu_model.cc:315:
> IDR_OMNIBOX_HTTPS_POLICY_WARNING));
> On 2015/07/10 19:04:16, Evan Stade wrote:
> > On 2015/07/10 10:46:37, Bernhard Bauer wrote:
> > > This seems a bit strange, and somewhat brittle, e.g. if the omnibox icon
is
> > > changed in the future.
> > > 
> > > If this is just about using the same warning icon, should we rename the
icon
> > > name to reflect that?
> > 
> > We probably want this to change if the omnibox icon changes (to maintain
> > consistency). My thinking was that this was no more brittle than it used to
be
> > because if the icons were changed in chrome://settings this one would also
> > magically change, for better or worse. If you prefer I guess I can leave the
> old
> > identifier and use it here, as it doesn't change the size of the pak file
> either
> > way.
> 
> Oh, I didn't realize this is actually a policy-related icon for the omnibox,
not
> a generic warning. In which case, either is fine with me.

ping Rachel

[Evan Stade, 2015-07-14 17:01:20]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-14 17:02:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227223004/20001

[commit-bot: I haz the power, 2015-07-14 17:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-14 17:18:39]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Evan Stade, 2015-07-15 21:57:22]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-07-15 21:57:22]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1227223004/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2015-07-15 21:59:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227223004/40001

[commit-bot: I haz the power, 2015-07-15 22:11:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 22:11:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2015-07-15 23:45:58]

estade@chromium.org changed reviewers:
+ benwells@chromium.org, oshima@chromium.org

[Evan Stade, 2015-07-15 23:45:58]

TBR'ing oshima for chrome/app/theme/ (just deleting files) and for
network_config_view.cc (trivial change)
TBR'ing benwells@chromium.org for extensions (trivial change)

[Evan Stade, 2015-07-15 23:48:46]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-07-15 23:48:47]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1227223004/#ps10021
(title: "rebase")

[commit-bot: I haz the power, 2015-07-15 23:49:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227223004/10021

[oshima, 2015-07-16 00:46:11]

c/a/theme lgtm

[benwells, 2015-07-16 00:47:31]

lgtm

[commit-bot: I haz the power, 2015-07-16 00:57:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 00:57:38]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-07-16 02:19:46]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-07-16 02:20:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1227223004/10021

[commit-bot: I haz the power, 2015-07-16 02:39:49]

Committed patchset #4 (id:10021)

[commit-bot: I haz the power, 2015-07-16 02:40:54]

Patchset 4 (id:??) landed as
https://crrev.com/54f65627c6129366504faf41650f5e61855a485d
Cr-Commit-Position: refs/heads/master@{#338974}

[rachelis, 2015-07-23 01:06:09]

lgtm

LGTM