Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1227213003: Debugger: ensure that functions with debug info have code with break slots. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: ensure that functions with debug info have code with break slots. This helps reasoning about setting break points. Functions that have debug info is also guaranteed to be able to set break points. R=ulan@chromium.org BUG=v8:4132 LOG=N Committed: https://crrev.com/83207b93f4d23e1df5c4f9bae1a97c8205b079e5 Cr-Commit-Position: refs/heads/master@{#29698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -32 lines) Patch
M src/debug.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +9 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 5 months ago (2015-07-15 10:30:46 UTC) #1
ulan
lgtm
5 years, 5 months ago (2015-07-15 10:48:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227213003/1
5 years, 5 months ago (2015-07-16 09:08:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 09:38:25 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 09:38:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83207b93f4d23e1df5c4f9bae1a97c8205b079e5
Cr-Commit-Position: refs/heads/master@{#29698}

Powered by Google App Engine
This is Rietveld 408576698