Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1227203009: fix sky_apk reference (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove unused code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-09 23:41:14 UTC) #2
Chinmay
lgtm
5 years, 5 months ago (2015-07-09 23:41:45 UTC) #3
jackson
https://codereview.chromium.org/1227203009/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1227203009/diff/1/BUILD.gn#newcode30 BUILD.gn:30: deps = [] I guess I should get rid ...
5 years, 5 months ago (2015-07-09 23:42:00 UTC) #4
jackson
Committed patchset #2 (id:20001) manually as 1a199ddf8e05a00f5b19ca0c341e4f3207ecc7a4 (presubmit successful).
5 years, 5 months ago (2015-07-09 23:42:55 UTC) #5
Chinmay
On 2015/07/09 at 23:42:00, jackson wrote: > https://codereview.chromium.org/1227203009/diff/1/BUILD.gn > File BUILD.gn (right): > > https://codereview.chromium.org/1227203009/diff/1/BUILD.gn#newcode30 ...
5 years, 5 months ago (2015-07-09 23:43:36 UTC) #6
jackson
5 years, 5 months ago (2015-07-09 23:50:14 UTC) #7
Message was sent while issue was closed.
fixed in https://codereview.chromium.org/1233493003

Powered by Google App Engine
This is Rietveld 408576698