Convert 'Testable' interface into an optional filter.

go/src/infra/gae/libs/gae/memory/taskqueue_test.go

Index: go/src/infra/gae/libs/gae/memory/taskqueue_test.go
diff --git a/go/src/infra/gae/libs/gae/memory/taskqueue_test.go b/go/src/infra/gae/libs/gae/memory/taskqueue_test.go
index 310ffe778e30e31e1dfdb64bc3427796cc94868d..35dd4f90288c2ba422967fbd8e285e2720ecd824 100644
--- a/go/src/infra/gae/libs/gae/memory/taskqueue_test.go
+++ b/go/src/infra/gae/libs/gae/memory/taskqueue_test.go
@@ -134,12 +134,6 @@ func TestTaskQueue(t *testing.T) {
 					So(err.Error(), ShouldContainSubstring, "INVALID_TASK_NAME")
 				})
 
-				Convey("can be broken", func() {
-					tq.BreakFeatures(nil, "Add")
-					_, err := tq.Add(t, "")
-					So(err.Error(), ShouldContainSubstring, "TRANSIENT_ERROR")
-				})
-
 				Convey("AddMulti also works", func() {
 					t2 := dupTask(t)
 					t2.Path = "/hi/city"
@@ -161,18 +155,6 @@ func TestTaskQueue(t *testing.T) {
 							So(tasks[i], ShouldResemble, expect[i])
 						})
 					}
-
-					Convey("can be broken", func() {
-						tq.BreakFeatures(nil, "AddMulti")
-						_, err := tq.AddMulti([]*gae.TQTask{t}, "")
-						So(err.Error(), ShouldContainSubstring, "TRANSIENT_ERROR")
-					})
-
-					Convey("is not broken by Add", func() {
-						tq.BreakFeatures(nil, "Add")
-						_, err := tq.AddMulti([]*gae.TQTask{t}, "")
-						So(err, ShouldBeNil)
-					})
 				})
 			})
 
@@ -218,12 +200,6 @@ func TestTaskQueue(t *testing.T) {
 					So(err.Error(), ShouldContainSubstring, "UNKNOWN_TASK")
 				})
 
-				Convey("can be broken", func() {
-					tq.BreakFeatures(nil, "Delete")
-					err := tq.Delete(t, "")
-					So(err.Error(), ShouldContainSubstring, "TRANSIENT_ERROR")
-				})
-
 				Convey("DeleteMulti also works", func() {
 					t2 := dupTask(t)
 					t2.Path = "/hi/city"
@@ -236,18 +212,6 @@ func TestTaskQueue(t *testing.T) {
 						So(len(tq.GetScheduledTasks()["default"]), ShouldEqual, 0)
 						So(len(tq.GetTombstonedTasks()["default"]), ShouldEqual, 2)
 					})
-
-					Convey("can be broken", func() {
-						tq.BreakFeatures(nil, "DeleteMulti")
-						err = tq.DeleteMulti([]*gae.TQTask{tEnQ, tEnQ2}, "")
-						So(err.Error(), ShouldContainSubstring, "TRANSIENT_ERROR")
-					})
-
-					Convey("is not broken by Delete", func() {
-						tq.BreakFeatures(nil, "Delete")
-						err = tq.DeleteMulti([]*gae.TQTask{tEnQ, tEnQ2}, "")
-						So(err, ShouldBeNil)
-					})
 				})
 			})
 		})
@@ -396,24 +360,6 @@ func TestTaskQueue(t *testing.T) {
 				}, nil)
 			})
 
-			Convey("unless Add is broken", func() {
-				tq.BreakFeatures(nil, "Add")
-				gae.GetRDS(c).RunInTransaction(func(c context.Context) error {
-					_, err = gae.GetTQ(c).Add(t, "")
-					So(err.Error(), ShouldContainSubstring, "TRANSIENT_ERROR")
-					return nil
-				}, nil)
-			})
-
-			Convey("unless AddMulti is broken", func() {
-				tq.BreakFeatures(nil, "AddMulti")
-				gae.GetRDS(c).RunInTransaction(func(c context.Context) error {
-					_, err = gae.GetTQ(c).AddMulti(nil, "")
-					So(err.Error(), ShouldContainSubstring, "TRANSIENT_ERROR")
-					return nil
-				}, nil)
-			})
-
 			Convey("No other features are available, however", func() {
 				err := error(nil)
 				func() {