Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: go/src/infra/gae/libs/gae/memory/globalinfo.go

Issue 1227203004: Convert 'Testable' interface into an optional filter. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@add_filters
Patch Set: final rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go/src/infra/gae/libs/gae/gae.infra_testing ('k') | go/src/infra/gae/libs/gae/memory/memcache.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/gae/libs/gae/memory/globalinfo.go
diff --git a/go/src/infra/gae/libs/gae/memory/globalinfo.go b/go/src/infra/gae/libs/gae/memory/globalinfo.go
index 87f42f0a1717e41fb4c3cb97539727f32d0c4449..172a1bb957a66bab5d09f6093f5be42f878ae3d2 100644
--- a/go/src/infra/gae/libs/gae/memory/globalinfo.go
+++ b/go/src/infra/gae/libs/gae/memory/globalinfo.go
@@ -34,8 +34,6 @@ func useGI(c context.Context) context.Context {
const globalAppID = "dev~app"
type globalInfoData struct {
- gae.BrokenFeatures
-
namespace string
}
@@ -48,14 +46,7 @@ type giImpl struct {
var _ = gae.GlobalInfo((*giImpl)(nil))
func (gi *giImpl) Namespace(ns string) (ret context.Context, err error) {
- err = gi.RunIfNotBroken(func() error {
- ret = context.WithValue(gi.c, giContextKey, &globalInfoData{
- curGID(gi.c).BrokenFeatures,
- ns,
- })
- return nil
- })
- return
+ return context.WithValue(gi.c, giContextKey, &globalInfoData{ns}), nil
}
func (gi *giImpl) AppID() string {
« no previous file with comments | « go/src/infra/gae/libs/gae/gae.infra_testing ('k') | go/src/infra/gae/libs/gae/memory/memcache.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698