Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3026)

Unified Diff: go/src/infra/gae/libs/gae/memory/datastore_query.go

Issue 1227183003: Change RawDatastore to do less reflection. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@move_dummy
Patch Set: Address self-comments and make pass new test.py Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: go/src/infra/gae/libs/gae/memory/datastore_query.go
diff --git a/go/src/infra/gae/libs/gae/memory/datastore_query.go b/go/src/infra/gae/libs/gae/memory/datastore_query.go
index b90048745417dc0ad2984a763668fe3ab6eff4a7..b8df9dc20db2977496b2e4765d578d47147e3b91 100644
--- a/go/src/infra/gae/libs/gae/memory/datastore_query.go
+++ b/go/src/infra/gae/libs/gae/memory/datastore_query.go
@@ -241,6 +241,8 @@ type queryIterImpl struct {
idx *queryImpl
}
+var _ gae.RDSIterator = (*queryIterImpl)(nil)
+
func (q *queryIterImpl) Cursor() (gae.DSCursor, error) {
if q.idx.err != nil {
return nil, q.idx.err
@@ -248,7 +250,7 @@ func (q *queryIterImpl) Cursor() (gae.DSCursor, error) {
return nil, nil
}
-func (q *queryIterImpl) Next(dst interface{}) (gae.DSKey, error) {
+func (q *queryIterImpl) Next(dst gae.DSPropertyLoadSaver) (gae.DSKey, error) {
if q.idx.err != nil {
return nil, q.idx.err
}

Powered by Google App Engine
This is Rietveld 408576698