Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: go/src/infra/gae/libs/gae/memory/testing_utils_test.go

Issue 1227183003: Change RawDatastore to do less reflection. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@move_dummy
Patch Set: fix No/ShouldIndex Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: go/src/infra/gae/libs/gae/memory/testing_utils_test.go
diff --git a/go/src/infra/gae/libs/gae/memory/testing_utils_test.go b/go/src/infra/gae/libs/gae/memory/testing_utils_test.go
index 81fdedbf46d2923625109b743eba0903397c4847..36948e27029006c8bc22926b96978134db039f23 100644
--- a/go/src/infra/gae/libs/gae/memory/testing_utils_test.go
+++ b/go/src/infra/gae/libs/gae/memory/testing_utils_test.go
@@ -35,16 +35,10 @@ func indx(kind string, orders ...string) *qIndex {
return ret
}
-func prop(val interface{}, noIndex ...bool) (ret gae.DSProperty) {
- ni := false
- if len(noIndex) > 0 {
- ni = noIndex[0]
- }
- if err := ret.SetValue(val, ni); err != nil {
- panic(err)
- }
- return
-}
+var (
+ prop = gae.MkDSProperty
+ propNI = gae.MkDSPropertyNI
+)
func key(kind string, id interface{}, parent ...gae.DSKey) gae.DSKey {
p := gae.DSKey(nil)
« no previous file with comments | « go/src/infra/gae/libs/gae/memory/raw_datstore_test.go ('k') | go/src/infra/gae/libs/gae/prod/datastore_key.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698