Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1227183002: Revert of cc: Make tile manager object persist for the length of LTHI. (Closed)

Created:
5 years, 5 months ago by vmpstr
Modified:
5 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Make tile manager object persist for the length of LTHI. (patchset #4 id:60001 of https://codereview.chromium.org/1210073020/) Reason for revert: Causing memory issues: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/33411/steps/memory%20test%3A%20compositor/logs/stdio Original issue's description: > cc: Make tile manager object persist for the length of LTHI. > > This patch makes TileManager be persistent throughout LTHI instead of > deleting and recreating it. This makes it possible to store items > on it that don't have to go away (such as PictureLayerTilingSets for > example). > > R=enne > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/792592da64887fc81e99c6588ad1b98a153db7ea > Cr-Commit-Position: refs/heads/master@{#337921} TBR=enne@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/c38c8fa67ecac0cba567e4e159b6676b021c437f Cr-Commit-Position: refs/heads/master@{#337944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -99 lines) Patch
M cc/test/fake_tile_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager.h View 3 chunks +5 lines, -12 lines 0 comments Download
M cc/tiles/tile_manager.cc View 8 chunks +13 lines, -47 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 12 chunks +44 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vmpstr
Created Revert of cc: Make tile manager object persist for the length of LTHI.
5 years, 5 months ago (2015-07-08 23:52:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227183002/1
5 years, 5 months ago (2015-07-08 23:53:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-08 23:56:01 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 23:57:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c38c8fa67ecac0cba567e4e159b6676b021c437f
Cr-Commit-Position: refs/heads/master@{#337944}

Powered by Google App Engine
This is Rietveld 408576698