chrome/browser/ssl/ssl_error_classification.h - Issue 1227173006: New SSL metric added: Likely From Same Domain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_error_classification.h

Issue 1227173006: New SSL metric added: Likely From Same Domain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolving Comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ssl/ssl_error_classification.h

diff --git a/chrome/browser/ssl/ssl_error_classification.h b/chrome/browser/ssl/ssl_error_classification.h

index 2eda135dfb616681c3a8c77120c7eee52067e927..89869b9ad6dc0f9804841523e57874b81aec24da 100644

--- a/chrome/browser/ssl/ssl_error_classification.h

+++ b/chrome/browser/ssl/ssl_error_classification.h

@@ -117,6 +117,11 @@ class SSLErrorClassification : public content::NotificationObserver {

// fields.

bool IsCertLikelyFromMultiTenantHosting() const;

+ // Returns true if the hostname in |request_url_| has the same domain

+ // (effective TLD + 1 label) as at least one of the subject

+ // alternative names in |cert_|.

+ bool IsCertLikelyFromSameDomain() const;

static std::vector<Tokens> GetTokenizedDNSNames(

const std::vector<std::string>& dns_names);