Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 1227173004: Removed -Wno-msvc-include suppression. (Closed)

Created:
5 years, 5 months ago by benwells
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed -Wno-msvc-include suppression. BUG=505299 Committed: https://crrev.com/c811a8d34b3633bcd2f08951edb01e31a376dca6 Cr-Commit-Position: refs/heads/master@{#338041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
The ICU problem in webkit is now fixed, and was the only problem I found ...
5 years, 5 months ago (2015-07-09 12:43:27 UTC) #2
Nico
On 2015/07/09 12:43:27, benwells wrote: > The ICU problem in webkit is now fixed, and ...
5 years, 5 months ago (2015-07-09 13:46:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227173004/1
5 years, 5 months ago (2015-07-09 13:46:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 15:07:03 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 15:07:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c811a8d34b3633bcd2f08951edb01e31a376dca6
Cr-Commit-Position: refs/heads/master@{#338041}

Powered by Google App Engine
This is Rietveld 408576698