Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1227163004: Revert of Re-enable ScreenOrientationBrowserTests on Chrome OS (Closed)

Created:
5 years, 5 months ago by Mattias Nissler (ping if slow)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mlamouri+watch-screen-orientation_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable ScreenOrientationBrowserTests on Chrome OS (patchset #1 id:1 of https://codereview.chromium.org/1225093002/) Reason for revert: Unfortunately, the tests still flake a lot: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/17013/steps/content_browsertests/logs/ScreenOrientationBrowserTest.WindowOrientationChange http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/17014/steps/content_browsertests/logs/ScreenOrientationBrowserTest.ScreenOrientationChange Original issue's description: > Re-enable ScreenOrientationBrowserTests on Chrome OS > Two tests were flaking on Chrome OS builds. > > Re-enabling to confirm that fixes to Screen Orientation API also fixed these tests. > > TEST=ScreenOrientationBrowserTest.ScreenOrientationChange, > ScreenOrientationBrowserTest.WindowOrientationChange > BUG=468259 > > Committed: https://crrev.com/4fa07d46cbdea4b263ad07beca29f90b42757c67 > Cr-Commit-Position: refs/heads/master@{#337950} TBR=mlamouri@chromium.org,jonross@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=468259 Committed: https://crrev.com/a6caa4b3bd9d29995c85dd8b8e75f0986125faf8 Cr-Commit-Position: refs/heads/master@{#338008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M content/browser/screen_orientation/screen_orientation_browsertest.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Created Revert of Re-enable ScreenOrientationBrowserTests on Chrome OS
5 years, 5 months ago (2015-07-09 10:03:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227163004/1
5 years, 5 months ago (2015-07-09 10:03:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 10:04:16 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 10:04:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6caa4b3bd9d29995c85dd8b8e75f0986125faf8
Cr-Commit-Position: refs/heads/master@{#338008}

Powered by Google App Engine
This is Rietveld 408576698