Update audio code to use size_t more correctly,

webrtc/modules/audio_coding/codecs/isac/fix/interface/isacfix.h

 /*
  *  Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_AUDIO_CODING_CODECS_ISAC_FIX_INTERFACE_ISACFIX_H_
 #define WEBRTC_MODULES_AUDIO_CODING_CODECS_ISAC_FIX_INTERFACE_ISACFIX_H_
 
+#include <stddef.h>
+
 #include "webrtc/modules/audio_coding/codecs/isac/bandwidth_info.h"
 #include "webrtc/typedefs.h"
 
 typedef struct {
   void *dummy;
 } ISACFIX_MainStruct;
 
 
 #if defined(__cplusplus)
 extern "C" {
@@ skipping 158 matching lines @@
 
 
   /****************************************************************************
    * WebRtcIsacfix_UpdateBwEstimate1(...)
    *
    * This function updates the estimate of the bandwidth.
    *
    * Input:
    *      - ISAC_main_inst    : ISAC instance.
    *      - encoded           : encoded ISAC frame(s).
    *      - packet_size       : size of the packet.

[minyue-webrtc, 2015/08/12 16:08:08]

could you update the comments for |packet_size| with its unit, like "size of the
packet in bytes" or "bytes of the packet",

also similar places.

[Peter Kasting, 2015/08/14 22:32:26]

Done (in this file)

    *      - rtp_seq_number    : the RTP number of the packet.
    *      - arr_ts            : the arrival time of the packet (from NetEq)
    *                            in samples.
    *
    * Return value             : 0 - Ok
    *                           -1 - Error
    */
 
   int16_t WebRtcIsacfix_UpdateBwEstimate1(ISACFIX_MainStruct *ISAC_main_inst,
                                           const uint8_t* encoded,
-                                          int32_t  packet_size,
+                                          size_t packet_size,
                                           uint16_t rtp_seq_number,
                                           uint32_t arr_ts);
 
   /****************************************************************************
    * WebRtcIsacfix_UpdateBwEstimate(...)
    *
    * This function updates the estimate of the bandwidth.
    *
    * Input:
    *      - ISAC_main_inst    : ISAC instance.
    *      - encoded           : encoded ISAC frame(s).
    *      - packet_size       : size of the packet.
    *      - rtp_seq_number    : the RTP number of the packet.
    *      - send_ts           : the send time of the packet from RTP header,
    *                            in samples.
    *      - arr_ts            : the arrival time of the packet (from NetEq)
    *                            in samples.
    *
    * Return value             :  0 - Ok
    *                            -1 - Error
    */
 
   int16_t WebRtcIsacfix_UpdateBwEstimate(ISACFIX_MainStruct *ISAC_main_inst,
                                          const uint8_t* encoded,
-                                         int32_t packet_size,
+                                         size_t packet_size,
                                          uint16_t rtp_seq_number,
                                          uint32_t send_ts,
                                          uint32_t arr_ts);
 
   /****************************************************************************
    * WebRtcIsacfix_Decode(...)
    *
    * This function decodes an ISAC frame. Output speech length
    * will be a multiple of 480 samples: 480 or 960 samples,
    * depending on the framesize (30 or 60 ms).
    *
    * Input:
    *      - ISAC_main_inst    : ISAC instance.
    *      - encoded           : encoded ISAC frame(s)
    *      - len               : bytes in encoded vector
    *
    * Output:
    *      - decoded           : The decoded vector
    *
    * Return value             : >0 - number of samples in decoded vector
    *                            -1 - Error
    */
 
   int WebRtcIsacfix_Decode(ISACFIX_MainStruct *ISAC_main_inst,
                            const uint8_t* encoded,
-                           int16_t len,
+                           size_t len,
                            int16_t *decoded,
                            int16_t *speechType);
 
 
   /****************************************************************************
    * WebRtcIsacfix_DecodeNb(...)
    *
    * This function decodes a ISAC frame in narrow-band (8 kHz sampling).
    * Output speech length will be a multiple of 240 samples: 240 or 480 samples,
    * depending on the framesize (30 or 60 ms).
    *
    * The function is enabled if WEBRTC_ISAC_FIX_NB_CALLS_ENABLED is defined
    *
    * Input:
    *      - ISAC_main_inst    : ISAC instance.
    *      - encoded           : encoded ISAC frame(s)
    *      - len               : bytes in encoded vector
    *
    * Output:
    *      - decoded           : The decoded vector
    *
    * Return value             : >0 - number of samples in decoded vector
    *                            -1 - Error
    */
 
 #ifdef WEBRTC_ISAC_FIX_NB_CALLS_ENABLED
   int WebRtcIsacfix_DecodeNb(ISACFIX_MainStruct *ISAC_main_inst,
                              const uint16_t *encoded,
-                             int16_t len,
+                             size_t len,
                              int16_t *decoded,
                              int16_t *speechType);
 #endif //  WEBRTC_ISAC_FIX_NB_CALLS_ENABLED
 
 
   /****************************************************************************
    * WebRtcIsacfix_DecodePlcNb(...)
    *
    * This function conducts PLC for ISAC frame(s) in narrow-band (8kHz sampling).
    * Output speech length  will be "240*noOfLostFrames" samples
    * that equevalent of "30*noOfLostFrames" millisecond.
    *
    * The function is enabled if WEBRTC_ISAC_FIX_NB_CALLS_ENABLED is defined
    *
    * Input:
    *      - ISAC_main_inst    : ISAC instance.
    *      - noOfLostFrames    : Number of PLC frames (240 sample=30ms) to produce
    *                            NOTE! Maximum number is 2 (480 samples = 60ms)
    *
    * Output:
    *      - decoded           : The decoded vector
    *
-   * Return value             : >0 - number of samples in decoded PLC vector
-   *                            -1 - Error
+   * Return value             : Number of samples in decoded PLC vector
    */
 
 #ifdef WEBRTC_ISAC_FIX_NB_CALLS_ENABLED
-  int16_t WebRtcIsacfix_DecodePlcNb(ISACFIX_MainStruct *ISAC_main_inst,
-                                    int16_t *decoded,
-                                    int16_t noOfLostFrames);
+  size_t WebRtcIsacfix_DecodePlcNb(ISACFIX_MainStruct *ISAC_main_inst,
+                                   int16_t *decoded,
+                                   size_t noOfLostFrames);
 #endif // WEBRTC_ISAC_FIX_NB_CALLS_ENABLED
 
 
 
 
   /****************************************************************************
    * WebRtcIsacfix_DecodePlc(...)
    *
    * This function conducts PLC for ISAC frame(s) in wide-band (16kHz sampling).
    * Output speech length  will be "480*noOfLostFrames" samples
    * that is equevalent of "30*noOfLostFrames" millisecond.
    *
    * Input:
    *      - ISAC_main_inst    : ISAC instance.
    *      - noOfLostFrames    : Number of PLC frames (480sample = 30ms)
    *                            to produce
    *                            NOTE! Maximum number is 2 (960 samples = 60ms)
    *
    * Output:
    *      - decoded           : The decoded vector
    *
-   * Return value             : >0 - number of samples in decoded PLC vector
-   *                            -1 - Error
+   * Return value             : Number of samples in decoded PLC vector
    */
 
-  int16_t WebRtcIsacfix_DecodePlc(ISACFIX_MainStruct *ISAC_main_inst,
-                                  int16_t *decoded,
-                                  int16_t noOfLostFrames );
+  size_t WebRtcIsacfix_DecodePlc(ISACFIX_MainStruct *ISAC_main_inst,
+                                 int16_t *decoded,
+                                 size_t noOfLostFrames );
 
 
   /****************************************************************************
    * WebRtcIsacfix_ReadFrameLen(...)
    *
    * This function returns the length of the frame represented in the packet.
    *
    * Input:
    *      - encoded           : Encoded bitstream
    *      - encoded_len_bytes : Length of the bitstream in bytes.
    *
    * Output:
    *      - frameLength       : Length of frame in packet (in samples)
    *
    */
 
   int16_t WebRtcIsacfix_ReadFrameLen(const uint8_t* encoded,
-                                     int encoded_len_bytes,
-                                     int16_t* frameLength);
+                                     size_t encoded_len_bytes,
+                                     size_t* frameLength);
 
   /****************************************************************************
    * WebRtcIsacfix_Control(...)
    *
    * This function sets the limit on the short-term average bit rate and the
    * frame length. Should be used only in Instantaneous mode.
    *
    * Input:
    *      - ISAC_main_inst    : ISAC instance.
    *      - rate              : limit on the short-term average bit rate,
@@ skipping 230 matching lines @@
    * Input:
    *      - encoded           : Encoded bitstream
    *      - encoded_len_bytes : Length of the bitstream in bytes.
    *
    * Output:
    *      - rateIndex         : Bandwidth estimate in bitstream
    *
    */
 
   int16_t WebRtcIsacfix_ReadBwIndex(const uint8_t* encoded,
-                                    int encoded_len_bytes,
+                                    size_t encoded_len_bytes,
                                     int16_t* rateIndex);
 
 
   /****************************************************************************
    * WebRtcIsacfix_GetNewFrameLen(...)
    *
    * This function return the next frame length (in samples) of iSAC.
    *
    * Input:
    *      -ISAC_main_inst     : iSAC instance
@@ skipping 11 matching lines @@
   void WebRtcIsacfix_SetBandwidthInfo(ISACFIX_MainStruct* ISAC_main_inst,
                                       const IsacBandwidthInfo* bwinfo);
 
 #if defined(__cplusplus)
 }
 #endif
 
 
 
 #endif /* WEBRTC_MODULES_AUDIO_CODING_CODECS_ISAC_FIX_INTERFACE_ISACFIX_H_ */