Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227153003: Remove setFromPaint from GrPipelineBuilder (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -71 lines) Patch
M gm/constcolorprocessor.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M include/gpu/GrDrawContext.h View 1 chunk +1 line, -7 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 9 chunks +18 lines, -29 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 3 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-09 19:23:35 UTC) #2
robertphillips
https://codereview.chromium.org/1227153003/diff/1/src/gpu/GrPipelineBuilder.h File src/gpu/GrPipelineBuilder.h (right): https://codereview.chromium.org/1227153003/diff/1/src/gpu/GrPipelineBuilder.h#newcode41 src/gpu/GrPipelineBuilder.h:41: /** view matrix -> clip ? https://codereview.chromium.org/1227153003/diff/1/src/gpu/GrStencilAndCoverTextContext.cpp File src/gpu/GrStencilAndCoverTextContext.cpp ...
5 years, 5 months ago (2015-07-09 19:52:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227153003/20001
5 years, 5 months ago (2015-07-09 20:17:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/999)
5 years, 5 months ago (2015-07-09 20:18:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227153003/20001
5 years, 5 months ago (2015-07-09 20:20:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/7b670db2b4eb0265e69038add7ae79441d77bbc5
5 years, 5 months ago (2015-07-09 20:25:05 UTC) #10
robertphillips
5 years, 5 months ago (2015-07-10 13:05:23 UTC) #11
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698