Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227153002: WebMediaRecorder: adding abstract classes to public/platform (Closed)

Created:
5 years, 5 months ago by mcasas
Modified:
5 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

WebMediaRecorder: adding abstract classes to public/platform See DD @ https://goo.gl/kreaQj for the plan and https://codereview.chromium.org/1211973012/ for a hack of all non-Blink parts together. BUG=262211

Patch Set 1 #

Total comments: 6

Patch Set 2 : slightlyoff@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
A public/platform/WebMediaRecorderHandler.h View 1 chunk +29 lines, -0 lines 0 comments Download
A public/platform/WebMediaRecorderHandlerClient.h View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
slightlyoff
https://codereview.chromium.org/1227153002/diff/1/public/platform/WebMediaRecorderHandler.h File public/platform/WebMediaRecorderHandler.h (right): https://codereview.chromium.org/1227153002/diff/1/public/platform/WebMediaRecorderHandler.h#newcode14 public/platform/WebMediaRecorderHandler.h:14: class WebMediaRecorderHandler { Is this class meant to be ...
5 years, 5 months ago (2015-07-20 01:12:07 UTC) #2
mcasas
slightlyoff@ PTAL https://codereview.chromium.org/1227153002/diff/1/public/platform/WebMediaRecorderHandler.h File public/platform/WebMediaRecorderHandler.h (right): https://codereview.chromium.org/1227153002/diff/1/public/platform/WebMediaRecorderHandler.h#newcode14 public/platform/WebMediaRecorderHandler.h:14: class WebMediaRecorderHandler { On 2015/07/20 01:12:06, slightlyoff ...
5 years, 5 months ago (2015-07-20 19:30:26 UTC) #3
mcasas
guidou@ PTAL
5 years, 5 months ago (2015-07-23 20:51:46 UTC) #5
slightlyoff
On 2015/07/23 20:51:46, mcasas wrote: > guidou@ PTAL LGTM
5 years, 5 months ago (2015-07-23 20:54:37 UTC) #6
mcasas
jochen@ Owners RS/PTAL/please forward appropriately :)
5 years, 5 months ago (2015-07-23 21:06:03 UTC) #8
Guido Urdaneta
lgtm
5 years, 5 months ago (2015-07-24 07:55:35 UTC) #9
jochen (gone - plz use gerrit)
as discussed offline, i'd rather have this together with the rest of the blink side ...
5 years, 5 months ago (2015-07-24 11:33:01 UTC) #10
mcasas
5 years, 4 months ago (2015-07-30 09:10:12 UTC) #11 
Closing this CL in favour of http://crrev.com/1255873002/,
thanks for your time and see you there.

Powered by Google App Engine
This is Rietveld 408576698