Update Analysis Server highlight API and implementation.

pkg/analysis_server/test/analysis/notification_highlights_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.analysis.notification.highlights;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol.dart';
@@ skipping 551 matching lines @@
   test_DIRECTIVE_partOf() {
     addTestFile('''
 part of lib;
 ''');
     _addLibraryForTestPart();
     return prepareHighlights().then((_) {
       assertHasStringRegion(HighlightRegionType.DIRECTIVE, "part of lib;");
     });
   }
 
-  test_DYNAMIC_TYPE() {
-    addTestFile('''
-f() {}
-main(p) {
-  print(p);
-  var v1 = f();
-  int v2;
-  var v3 = v2;
-}
-''');
-    return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.DYNAMIC_TYPE, 'p)');
-      assertHasRegion(HighlightRegionType.DYNAMIC_TYPE, 'v1 =');
-      assertNoRegion(HighlightRegionType.DYNAMIC_TYPE, 'v2;');
-      assertNoRegion(HighlightRegionType.DYNAMIC_TYPE, 'v3 =');
-    });
-  }
-
   test_ENUM() {
     addTestFile('''
 enum MyEnum {A, B, C}
 MyEnum value;
 ''');
     return prepareHighlights().then((_) {
       assertHasRegion(HighlightRegionType.ENUM, 'MyEnum {');
       assertHasRegion(HighlightRegionType.ENUM, 'MyEnum value;');
     });
   }
 
   test_ENUM_CONSTANT() {
     addTestFile('''
 enum MyEnum {AAA, BBB}
 main() {
   print(MyEnum.AAA);
   print(MyEnum.BBB);
 }
 ''');
     return prepareHighlights().then((_) {
       assertHasRegion(HighlightRegionType.ENUM_CONSTANT, 'AAA, ');
       assertHasRegion(HighlightRegionType.ENUM_CONSTANT, 'BBB}');
       assertHasRegion(HighlightRegionType.ENUM_CONSTANT, 'AAA);');
       assertHasRegion(HighlightRegionType.ENUM_CONSTANT, 'BBB);');
     });
   }
 
-  test_FIELD() {
+  solo_test_LOCAL_FUNCTION() {

[Brian Wilkerson, 2015/07/09 13:58:20]

Remove "solo_" prefix.

[scheglov, 2015/07/09 15:36:22]

Done.

     addTestFile('''
-class A {
-  int aaa = 1;
-  int bbb = 2;
-  A([this.bbb = 3]);
-}
-main(A a) {
-  a.aaa = 4;
-  a.bbb = 5;
+main() {
+  fff() {}
+  fff();
+  fff;
 }
 ''');
     return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.FIELD, 'aaa = 1');
-      assertHasRegion(HighlightRegionType.FIELD, 'bbb = 2');
-      assertHasRegion(HighlightRegionType.FIELD, 'bbb = 3');
-      assertHasRegion(HighlightRegionType.FIELD, 'aaa = 4');
-      assertHasRegion(HighlightRegionType.FIELD, 'bbb = 5');
+      assertHasRegion(
+          HighlightRegionType.LOCAL_FUNCTION_DECLARATION, 'fff() {}');
+      assertHasRegion(HighlightRegionType.LOCAL_FUNCTION_REFERENCE, 'fff();');
+      assertHasRegion(HighlightRegionType.LOCAL_FUNCTION_REFERENCE, 'fff;');
     });
   }
 
-  test_FIELD_STATIC() {
-    addTestFile('''
-class A {
-  static aaa = 1;
-  static get bbb => null;
-  static set ccc(x) {}
-}
-main() {
-  A.aaa = 2;
-  A.bbb;
-  A.ccc = 3;
-}
-''');
-    return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.FIELD_STATIC, 'aaa = 1');
-      assertHasRegion(HighlightRegionType.FIELD_STATIC, 'aaa = 2');
-      assertHasRegion(HighlightRegionType.FIELD_STATIC, 'bbb;');
-      assertHasRegion(HighlightRegionType.FIELD_STATIC, 'ccc = 3');
-    });
-  }
-
-  test_FUNCTION() {
-    addTestFile('''
-fff(p) {}
-main() {
-  fff(42);
-}
-''');
-    return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.FUNCTION_DECLARATION, 'fff(p) {}');
-      assertHasRegion(HighlightRegionType.FUNCTION, 'fff(42)');
-    });
-  }
-
   test_FUNCTION_TYPE_ALIAS() {
     addTestFile('''
 typedef FFF(p);
 main(FFF fff) {
 }
 ''');
     return prepareHighlights().then((_) {
       assertHasRegion(HighlightRegionType.FUNCTION_TYPE_ALIAS, 'FFF(p)');
       assertHasRegion(HighlightRegionType.FUNCTION_TYPE_ALIAS, 'FFF fff)');
     });
   }
 
-  test_GETTER_DECLARATION() {
+  test_GETTER() {
     addTestFile('''
 get aaa => null;
 class A {
   get bbb => null;
+  static get ccc => null;
 }
 main(A a) {
   aaa;
   a.bbb;
+  A.ccc;
 }
 ''');
     return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.GETTER_DECLARATION, 'aaa => null');
-      assertHasRegion(HighlightRegionType.GETTER_DECLARATION, 'bbb => null');
-      assertHasRegion(HighlightRegionType.TOP_LEVEL_VARIABLE, 'aaa;');
-      assertHasRegion(HighlightRegionType.FIELD, 'bbb;');
+      assertHasRegion(
+          HighlightRegionType.TOP_LEVEL_GETTER_DECLARATION, 'aaa => null');
+      assertHasRegion(
+          HighlightRegionType.INSTANCE_GETTER_DECLARATION, 'bbb => null');
+      assertHasRegion(
+          HighlightRegionType.STATIC_GETTER_DECLARATION, 'ccc => null');
+      assertHasRegion(HighlightRegionType.TOP_LEVEL_VARIABLE_REFERENCE, 'aaa;');
+      assertHasRegion(HighlightRegionType.INSTANCE_FIELD_REFERENCE, 'bbb;');
+      assertHasRegion(HighlightRegionType.STATIC_FIELD_REFERENCE, 'ccc;');
     });
   }
 
   test_IDENTIFIER_DEFAULT() {
     addTestFile('''
 main() {
   aaa = 42;
   bbb(84);
   CCC ccc;
 }
@@ skipping 11 matching lines @@
 main() {
   ma.max(1, 2);
 }
 ''');
     return prepareHighlights().then((_) {
       assertHasRegion(HighlightRegionType.IMPORT_PREFIX, 'ma;');
       assertHasRegion(HighlightRegionType.IMPORT_PREFIX, 'ma.max');
     });
   }
 
+  test_INSTANCE_FIELD() {
+    addTestFile('''
+class A {
+  int aaa = 1;
+  int bbb = 2;
+  A([this.bbb = 3]);
+}
+main(A a) {
+  a.aaa = 4;
+  a.bbb = 5;
+}
+''');
+    return prepareHighlights().then((_) {
+      assertHasRegion(
+          HighlightRegionType.INSTANCE_FIELD_DECLARATION, 'aaa = 1');
+      assertHasRegion(
+          HighlightRegionType.INSTANCE_FIELD_DECLARATION, 'bbb = 2');
+      assertHasRegion(HighlightRegionType.INSTANCE_FIELD_REFERENCE, 'bbb = 3');
+      assertHasRegion(HighlightRegionType.INSTANCE_FIELD_REFERENCE, 'aaa = 4');
+      assertHasRegion(HighlightRegionType.INSTANCE_FIELD_REFERENCE, 'bbb = 5');
+    });
+  }
+
   test_KEYWORD() {
     addTestFile('''
 main() {
   assert(true);
   for (;;) break;
   switch (0) {
     case 0: break;
     default: break;
   }
   try {} catch (e) {}
@@ skipping 125 matching lines @@
     addTestFile('''
 main() {
   int vvv = 0;
   vvv;
   vvv = 1;
 }
 ''');
     return prepareHighlights().then((_) {
       assertHasRegion(
           HighlightRegionType.LOCAL_VARIABLE_DECLARATION, 'vvv = 0');
-      assertHasRegion(HighlightRegionType.LOCAL_VARIABLE, 'vvv;');
-      assertHasRegion(HighlightRegionType.LOCAL_VARIABLE, 'vvv = 1;');
+      assertHasRegion(HighlightRegionType.LOCAL_VARIABLE_REFERENCE, 'vvv;');
+      assertHasRegion(HighlightRegionType.LOCAL_VARIABLE_REFERENCE, 'vvv = 1;');
     });
   }
 
   test_METHOD() {
     addTestFile('''
 class A {
   aaa() {}
   static bbb() {}
 }
 main(A a) {
   a.aaa();
   a.aaa;
   A.bbb();
   A.bbb;
 }
 ''');
     return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.METHOD_DECLARATION, 'aaa() {}');
       assertHasRegion(
-          HighlightRegionType.METHOD_DECLARATION_STATIC, 'bbb() {}');
-      assertHasRegion(HighlightRegionType.METHOD, 'aaa();');
-      assertHasRegion(HighlightRegionType.METHOD, 'aaa;');
-      assertHasRegion(HighlightRegionType.METHOD_STATIC, 'bbb();');
-      assertHasRegion(HighlightRegionType.METHOD_STATIC, 'bbb;');
+          HighlightRegionType.INSTANCE_METHOD_DECLARATION, 'aaa() {}');
+      assertHasRegion(
+          HighlightRegionType.STATIC_METHOD_DECLARATION, 'bbb() {}');
+      assertHasRegion(HighlightRegionType.INSTANCE_METHOD_REFERENCE, 'aaa();');
+      assertHasRegion(HighlightRegionType.INSTANCE_METHOD_REFERENCE, 'aaa;');
+      assertHasRegion(HighlightRegionType.STATIC_METHOD_REFERENCE, 'bbb();');
+      assertHasRegion(HighlightRegionType.STATIC_METHOD_REFERENCE, 'bbb;');
     });
   }
 
   test_METHOD_bestType() {
     addTestFile('''
 main(p) {
   if (p is List) {
     p.add(null);
   }
 }
 ''');
     return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.METHOD, 'add(null)');
+      assertHasRegion(
+          HighlightRegionType.INSTANCE_METHOD_REFERENCE, 'add(null)');
     });
   }
 
   test_PARAMETER() {
     addTestFile('''
 main(int p) {
   p;
   p = 42;
 }
 ''');
     return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.PARAMETER, 'p) {');
-      assertHasRegion(HighlightRegionType.PARAMETER, 'p;');
-      assertHasRegion(HighlightRegionType.PARAMETER, 'p = 42');
+      assertHasRegion(HighlightRegionType.PARAMETER_DECLARATION, 'p) {');
+      assertHasRegion(HighlightRegionType.PARAMETER_REFERENCE, 'p;');
+      assertHasRegion(HighlightRegionType.PARAMETER_REFERENCE, 'p = 42');
     });
   }
 
   test_SETTER_DECLARATION() {
     addTestFile('''
 set aaa(x) {}
 class A {
   set bbb(x) {}
+  static set ccc(x) {}
 }
 main(A a) {
   aaa = 1;
   a.bbb = 2;
+  A.ccc = 3;
 }
 ''');
     return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.SETTER_DECLARATION, 'aaa(x)');
-      assertHasRegion(HighlightRegionType.SETTER_DECLARATION, 'bbb(x)');
-      assertHasRegion(HighlightRegionType.TOP_LEVEL_VARIABLE, 'aaa = 1');
-      assertHasRegion(HighlightRegionType.FIELD, 'bbb = 2');
+      assertHasRegion(
+          HighlightRegionType.TOP_LEVEL_SETTER_DECLARATION, 'aaa(x)');
+      assertHasRegion(
+          HighlightRegionType.INSTANCE_SETTER_DECLARATION, 'bbb(x)');
+      assertHasRegion(HighlightRegionType.STATIC_SETTER_DECLARATION, 'ccc(x)');
+      assertHasRegion(
+          HighlightRegionType.TOP_LEVEL_VARIABLE_REFERENCE, 'aaa = 1');
+      assertHasRegion(HighlightRegionType.INSTANCE_FIELD_REFERENCE, 'bbb = 2');
+      assertHasRegion(HighlightRegionType.STATIC_FIELD_REFERENCE, 'ccc = 3');
     });
   }
 
+  test_STATIC_FIELD() {
+    addTestFile('''
+class A {
+  static aaa = 1;
+  static get bbb => null;
+  static set ccc(x) {}
+}
+main() {
+  A.aaa = 2;
+  A.bbb;
+  A.ccc = 3;
+}
+''');
+    return prepareHighlights().then((_) {
+      assertHasRegion(HighlightRegionType.STATIC_FIELD_DECLARATION, 'aaa = 1');
+      assertHasRegion(HighlightRegionType.STATIC_FIELD_REFERENCE, 'aaa = 2');
+      assertHasRegion(HighlightRegionType.STATIC_FIELD_REFERENCE, 'bbb;');
+      assertHasRegion(HighlightRegionType.STATIC_FIELD_REFERENCE, 'ccc = 3');
+    });
+  }
+
+  test_TOP_LEVEL_FUNCTION() {
+    addTestFile('''
+fff(p) {}
+main() {
+  fff(42);
+}
+''');
+    return prepareHighlights().then((_) {
+      assertHasRegion(
+          HighlightRegionType.TOP_LEVEL_FUNCTION_DECLARATION, 'fff(p) {}');
+      assertHasRegion(
+          HighlightRegionType.TOP_LEVEL_FUNCTION_REFERENCE, 'fff(42)');
+    });
+  }
+
   test_TOP_LEVEL_VARIABLE() {
     addTestFile('''
 const VVV = 0;
 @VVV // annotation
 main() {
   print(VVV);
   VVV = 1;
 }
 ''');
     return prepareHighlights().then((_) {
-      assertHasRegion(HighlightRegionType.TOP_LEVEL_VARIABLE, 'VVV = 0');
       assertHasRegion(
-          HighlightRegionType.TOP_LEVEL_VARIABLE, 'VVV // annotation');
-      assertHasRegion(HighlightRegionType.TOP_LEVEL_VARIABLE, 'VVV);');
-      assertHasRegion(HighlightRegionType.TOP_LEVEL_VARIABLE, 'VVV = 1');
+          HighlightRegionType.TOP_LEVEL_VARIABLE_DECLARATION, 'VVV = 0');
+      assertHasRegion(HighlightRegionType.TOP_LEVEL_VARIABLE_REFERENCE,
+          'VVV // annotation');
+      assertHasRegion(
+          HighlightRegionType.TOP_LEVEL_VARIABLE_REFERENCE, 'VVV);');
+      assertHasRegion(
+          HighlightRegionType.TOP_LEVEL_VARIABLE_REFERENCE, 'VVV = 1');
     });
   }
 
   test_TYPE_NAME_DYNAMIC() {
     addTestFile('''
 dynamic main() {
   dynamic = 42;
 }
 ''');
     return prepareHighlights().then((_) {
@@ skipping 11 matching lines @@
 }
 ''');
     return prepareHighlights().then((_) {
       assertHasRegion(HighlightRegionType.TYPE_PARAMETER, 'T> {');
       assertHasRegion(HighlightRegionType.TYPE_PARAMETER, 'T fff;');
       assertHasRegion(HighlightRegionType.TYPE_PARAMETER, 'T mmm(');
       assertHasRegion(HighlightRegionType.TYPE_PARAMETER, 'T p)');
     });
   }
 
+  test_UNTYPED_VARIABLE() {
+    addTestFile('''
+f() {}
+main(p) {
+  print(p);
+  var v1 = f();
+  int v2;
+  var v3 = v2;
+}
+''');
+    return prepareHighlights().then((_) {
+      assertHasRegion(HighlightRegionType.UNTYPED_VARIABLE, 'p)');
+      assertHasRegion(HighlightRegionType.UNTYPED_VARIABLE, 'v1 =');
+      assertNoRegion(HighlightRegionType.UNTYPED_VARIABLE, 'v2;');
+      assertNoRegion(HighlightRegionType.UNTYPED_VARIABLE, 'v3 =');
+    });
+  }
+
   void _addLibraryForTestPart() {
     addFile('$testFolder/my_lib.dart', '''
 library lib;
 part 'test.dart';
     ''');
   }
 }
 
 @reflectiveTest
 class HighlightTypeTest {
   void test_constructor() {
     expect(HighlightRegionType.CLASS,
         new HighlightRegionType(HighlightRegionType.CLASS.name));
   }
 
   void test_toString() {
     expect(HighlightRegionType.CLASS.toString(), 'HighlightRegionType.CLASS');
   }
 
   void test_valueOf_unknown() {
     expect(() {
       new HighlightRegionType('no-such-type');
     }, throws);
   }
 }