Issue 1227113002: Define SK_LEGACY_IMAGE_GENERATOR_ENUMS_AND_OPTIONS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1227113002: Define SK_LEGACY_IMAGE_GENERATOR_ENUMS_AND_OPTIONS (Closed)

Created:
5 years, 5 months ago by scroggo_chromium

Modified:
5 years, 5 months ago

Reviewers:
scroggo, reed1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Define SK_LEGACY_IMAGE_GENERATOR_ENUMS_AND_OPTIONS This will allow us to stage the change that will remove legacy features from SkImageGenerator (see https://codereview.chromium.org/1226023003/ in Skia). Committed: https://crrev.com/414ace50483ecf98debd9f5ae4f75f1c6124dd05 Cr-Commit-Position: refs/heads/master@{#337909}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	skia/config/SkUserConfig.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

scroggo

Note that the description has a link to a different CL (one in Skia).

5 years, 5 months ago (2015-07-08 20:45:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227113002/1

5 years, 5 months ago (2015-07-08 21:15:42 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-08 21:26:46 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/414ace50483ecf98debd9f5ae4f75f1c6124dd05
Cr-Commit-Position: refs/heads/master@{#337909}