Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 12271004: Fixing node.nodes.addAll to accept node lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/html/node_test.dart ('k') | tools/dom/templates/html/impl/impl_Node.darttemplate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index f4f9de1c083215a2c8b0dadb52e8fd550c406d6b..791b1ab6f76b14a6a3d9731c60b3a8e4cfaf6c67 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -140,6 +140,10 @@ class _ChildrenElementList implements List {
Iterator<Element> get iterator => toList().iterator;
void addAll(Iterable<Element> iterable) {
+ if (iterable is _ChildNodeListLazy) {
+ iterable = new List.from(iterable);
+ }
+
for (Element element in iterable) {
_element.$dom_appendChild(element);
}
« no previous file with comments | « tests/html/node_test.dart ('k') | tools/dom/templates/html/impl/impl_Node.darttemplate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698