Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1227093010: Add an AspectRatio widget for doing proportional height sizing (Closed)

Created:
5 years, 5 months ago by eseidel
Modified:
5 years, 5 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add an AspectRatio widget for doing proportional height sizing This is needed for Material Design since rich media is supposed to be displayed as 16:9 when possible. http://www.google.com/design/spec/components/cards.html#cards-content-blocks R=abarth@chromium.org, abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/0d208c5e88259d5e9ceece3af761a8749ff10e78

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M sky/sdk/example/address_book/lib/main.dart View 3 chunks +10 lines, -4 lines 2 comments Download
M sky/sdk/lib/rendering/box.dart View 1 chunk +46 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/basic.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
abarth-chromium
lgtm https://codereview.chromium.org/1227093010/diff/1/sky/sdk/example/address_book/lib/main.dart File sky/sdk/example/address_book/lib/main.dart (right): https://codereview.chromium.org/1227093010/diff/1/sky/sdk/example/address_book/lib/main.dart#newcode60 sky/sdk/example/address_book/lib/main.dart:60: aspectRatio: 16 / 9, Does this need to ...
5 years, 5 months ago (2015-07-14 20:17:02 UTC) #2
eseidel
Committed patchset #1 (id:1) manually as 0d208c5e88259d5e9ceece3af761a8749ff10e78 (presubmit successful).
5 years, 5 months ago (2015-07-14 20:17:59 UTC) #3
Cutch
5 years, 5 months ago (2015-07-14 20:33:44 UTC) #5
Message was sent while issue was closed. 
DBC

https://codereview.chromium.org/1227093010/diff/1/sky/sdk/example/address_boo...
File sky/sdk/example/address_book/lib/main.dart (right):

https://codereview.chromium.org/1227093010/diff/1/sky/sdk/example/address_boo...
sky/sdk/example/address_book/lib/main.dart:60: aspectRatio: 16 / 9,
On 2015/07/14 20:17:02, abarth-chromium wrote:
> Does this need to be 16.0 / 9.0 to get floating point division?

16 / 9 will be a floating point division on two integers. Better would be to
write:

16.0 / 9.0

Powered by Google App Engine
This is Rietveld 408576698