Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4694)

Unified Diff: chrome/browser/extensions/events_apitest.cc

Issue 1227093008: Clear an extension's filtered events when a context is destroyed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moar Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/value_counter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/events_apitest.cc
diff --git a/chrome/browser/extensions/events_apitest.cc b/chrome/browser/extensions/events_apitest.cc
index 6184bb6b28452638bfb38e901ed74f2aab9cd40e..8787df1e60d083be72a850e2172ccf85857c39bf 100644
--- a/chrome/browser/extensions/events_apitest.cc
+++ b/chrome/browser/extensions/events_apitest.cc
@@ -45,7 +45,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, EventsAreUnregistered) {
const std::string& id = extension->id();
// The page has closed, so no matter what all events are no longer listened
- // to.
+ // to. Assertions for normal events:
EXPECT_FALSE(
event_router->ExtensionHasEventListener(id, "browserAction.onClicked"));
EXPECT_FALSE(
@@ -54,6 +54,15 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, EventsAreUnregistered) {
event_router->ExtensionHasEventListener(id, "runtime.onSuspend"));
EXPECT_FALSE(
event_router->ExtensionHasEventListener(id, "runtime.onInstalled"));
+ // Assertions for filtered events:
+ EXPECT_FALSE(event_router->ExtensionHasEventListener(
+ id, "webNavigation.onBeforeNavigate"));
+ EXPECT_FALSE(
+ event_router->ExtensionHasEventListener(id, "webNavigation.onCommitted"));
+ EXPECT_FALSE(event_router->ExtensionHasEventListener(
+ id, "webNavigation.onDOMContentLoaded"));
+ EXPECT_FALSE(
+ event_router->ExtensionHasEventListener(id, "webNavigation.onCompleted"));
}
} // namespace extensions
« no previous file with comments | « no previous file | chrome/common/extensions/value_counter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698