Clear an extension's filtered events when a context is destroyed.

extensions/renderer/event_bindings.h

Index: extensions/renderer/event_bindings.h
diff --git a/extensions/renderer/event_bindings.h b/extensions/renderer/event_bindings.h
index cf06692c3bb800226d9f633778315874f5bdec61..55aee3d4ade452ec6c35b49ce3fb6800de7c33f0 100644
--- a/extensions/renderer/event_bindings.h
+++ b/extensions/renderer/event_bindings.h
@@ -53,23 +53,32 @@ class EventBindings : public ObjectBackedNativeHandler {
   // to MatchAgainstEventFilter where this listener matches.
   void AttachFilteredEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
 
+  // JavaScript handler which forwards to DetachFilteredEvent.
   // void DetachFilteredEvent(int id, bool manual)
-  // id     - Id of the event to detach.
-  // manual - false if this is part of the extension unload process where all
-  //          listeners are automatically detached.
-  void DetachFilteredEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
+  // args[0] forwards to |matcher_id|
+  // args[1] forwards to |is_manual|
+  void DetachFilteredEventHandler(
+      const v8::FunctionCallbackInfo<v8::Value>& args);
+
+  // Detaches a filtered event. Unlike normal events, filtered events are
+  // identified by an ID, not its name.
+  // |matcher_id| The ID of the filtered event.
+  // |is_manual| false if this is part of the extension unload process where all
+  // listeners are automatically detached.
+  void DetachFilteredEvent(int event_id, bool is_manual);

[Devlin, 2015/07/10 17:57:30]

|matcher_id|?

[not at google - send to devlin, 2015/07/10 20:39:17]

Done.

 
   void MatchAgainstEventFilter(const v8::FunctionCallbackInfo<v8::Value>& args);
 
   scoped_ptr<EventMatcher> ParseEventMatcher(
-      base::DictionaryValue* filter_dict);
+      scoped_ptr<base::DictionaryValue> filter);
 
   // Called when our context, and therefore us, is invalidated. Run any cleanup.
   void OnInvalidated();
 
-  // The set of attached events. Maintain this so that we can detch them on
-  // unload.
+  // The set of attached events and filtered events. Maintain this so that we

[Devlin, 2015/07/10 17:57:30]

nit: "maintain these"?

[not at google - send to devlin, 2015/07/10 20:39:17]

Done.

+  // can detch them on unload.
   std::set<std::string> attached_event_names_;
+  std::set<int> attached_matcher_ids_;
 
   DISALLOW_COPY_AND_ASSIGN(EventBindings);
 };