Fix uses of eval() with non-string arguments under nosnap/--use-strict

src/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/api.h"
 #include "src/ast.h"
 #include "src/ast-literal-reindexer.h"
 #include "src/bailout-reason.h"
@@ skipping 1122 matching lines @@
 
 
 FunctionLiteral* Parser::ParseLazy(Isolate* isolate, ParseInfo* info,
                                    Utf16CharacterStream* source) {
   Handle<SharedFunctionInfo> shared_info = info->shared_info();
   scanner_.Initialize(source);
   DCHECK(scope_ == NULL);
   DCHECK(target_stack_ == NULL);
 
   Handle<String> name(String::cast(shared_info->name()));
+
+  // If we're lazy-compiling 'eval' itself, blank out its name to avoid
+  // spurious "Unexpected eval in strict mode" errors.
+  if (info->is_native() && *name == isolate->heap()->eval_string()) {
+    name = isolate->factory()->empty_string();

[arv (Not doing code reviews), 2015/07/09 19:00:59]

Would it be possible to skip the name check instead of changing name?

[adamk, 2015/07/09 19:09:00]

Hmm, I see we already have a bool flag we pass to ParseFunctionLiteral for other
strict reserved words...it might be possible to simply widen the scope of that
override.

+  }
+
   DCHECK(ast_value_factory());
   fni_ = new (zone()) FuncNameInferrer(ast_value_factory(), zone());
   const AstRawString* raw_name = ast_value_factory()->GetString(name);
   fni_->PushEnclosingName(raw_name);
 
   ParsingModeScope parsing_mode(this, PARSE_EAGERLY);
 
   // Place holder for the result.
   FunctionLiteral* result = NULL;
 
@@ skipping 4791 matching lines @@
 Expression* Parser::SpreadCallNew(Expression* function,
                                   ZoneList<v8::internal::Expression*>* args,
                                   int pos) {
   args->InsertAt(0, function, zone());
 
   return factory()->NewCallRuntime(
       ast_value_factory()->reflect_construct_string(), NULL, args, pos);
 }
 }  // namespace internal
 }  // namespace v8