Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 1227033002: [test] Refactoring - Make perf suite definitions stateless regarding measurements. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
Reviewers:
ulan, tandrii(chromium)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Refactoring - Make perf suite definitions stateless regarding measurements. This prepares for making multiple measurements of one trace. For this, the suite/trace configurations need to be independent of the measurement instances. BUG=chromium:507213 LOG=n NOTRY=true Committed: https://crrev.com/373d7396503212d8d939e18a2e55436ae57998a2 Cr-Commit-Position: refs/heads/master@{#29531}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Renaming of configs #

Total comments: 2

Patch Set 3 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -128 lines) Patch
M tools/run_perf.py View 1 2 9 chunks +180 lines, -128 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/1227033002/diff/1/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/1227033002/diff/1/tools/run_perf.py#newcode173 tools/run_perf.py:173: """Represents a series of results of one trace. ...
5 years, 5 months ago (2015-07-08 10:03:19 UTC) #2
Michael Achenbach
Patch 2 does some renaming.
5 years, 5 months ago (2015-07-08 12:14:05 UTC) #3
ulan
lgtm https://codereview.chromium.org/1227033002/diff/20001/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/1227033002/diff/20001/tools/run_perf.py#newcode236 tools/run_perf.py:236: res = reduce(lambda r, t: r + t.GetResults(), ...
5 years, 5 months ago (2015-07-08 12:26:32 UTC) #4
Michael Achenbach
https://codereview.chromium.org/1227033002/diff/20001/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/1227033002/diff/20001/tools/run_perf.py#newcode236 tools/run_perf.py:236: res = reduce(lambda r, t: r + t.GetResults(), measurements, ...
5 years, 5 months ago (2015-07-08 12:29:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1227033002/40001
5 years, 5 months ago (2015-07-08 12:30:03 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-08 12:31:34 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 12:31:52 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/373d7396503212d8d939e18a2e55436ae57998a2
Cr-Commit-Position: refs/heads/master@{#29531}

Powered by Google App Engine
This is Rietveld 408576698