Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc

Issue 1226933004: Use a shorter title for the credit card unmask dialog on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
diff --git a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc b/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
index 82d0045770c0ab6d34ec1b66ed23450516448385..d7b5601c14e6e4203c4a49f8ae4a6f337b1db798 100644
--- a/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
+++ b/components/autofill/core/browser/ui/card_unmask_prompt_controller_impl.cc
@@ -214,10 +214,17 @@ void CardUnmaskPromptControllerImpl::NewCardLinkClicked() {
}
base::string16 CardUnmaskPromptControllerImpl::GetWindowTitle() const {
+#if defined(OS_IOS)
+ // The iOS UI has less room for the title and places a "Verify" button right
+ // next to it so the full title ("Verify your" + type and last four) is
+ // unnecessary.
+ return card_.TypeAndLastFourDigits();
+#else
int ids = ShouldRequestExpirationDate()
? IDS_AUTOFILL_CARD_UNMASK_PROMPT_UPDATE_TITLE
: IDS_AUTOFILL_CARD_UNMASK_PROMPT_TITLE;
return l10n_util::GetStringFUTF16(ids, card_.TypeAndLastFourDigits());
+#endif
}
base::string16 CardUnmaskPromptControllerImpl::GetInstructionsMessage() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698