Issue 1226933003: fix pathops battle test

Issue 1226933003: fix pathops battle test (Closed)

Created:
5 years, 5 months ago by caryclark

Modified:
5 years, 5 months ago

Reviewers:
rmistry, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

fix pathops battle test The intermediate subtraction threw away bits causing the subsequent cross product to fail. Defer the bit truncation until after the vector is computed. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/fc95be17c3f294a86e7ba82790e38cd7ae7146eb

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -44 lines)			Patch
M	src/pathops/SkOpAngle.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/PathOpsBattles.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/pathops_sorter.htm	View	1 chunk	+3 lines, -41 lines	0 comments	Download

Total messages: 9 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226933003/1

5 years, 5 months ago (2015-07-07 21:15:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226933003/1

5 years, 5 months ago (2015-07-07 22:21:25 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226933003/1

5 years, 5 months ago (2015-07-08 00:55:49 UTC) #8

commit-bot: I haz the power

5 years, 5 months ago (2015-07-08 01:09:37 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fc95be17c3f294a86e7ba82790e38cd7ae7146eb