Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1226933002: [tracing] Fix memory overhead accounting of TraceBufferVector (Closed)

Created:
5 years, 5 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
petrcermak
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org, bashi, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Fix memory overhead accounting of TraceBufferVector When tracing estimates the memory overhead of its own structs TraceBufferVector (which itself is just a vector of pointers) doesn't take into account its own capacity. This causes sub-accounting when using the "as much as possible" record strategy, which causes a big upfront reservation. BUG=495628 Committed: https://crrev.com/954f418961681edbaeb354d59c078b304a863a03 Cr-Commit-Position: refs/heads/master@{#337624}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M base/trace_event/trace_event_impl.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Primiano Tucci (use gerrit)
petrcermak@ PTAL FYI bashi@ haraken@, this is where the extra malloc things come from when ...
5 years, 5 months ago (2015-07-07 15:55:40 UTC) #2
petrcermak
LGTM. Thanks, Petr
5 years, 5 months ago (2015-07-07 16:00:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226933002/1
5 years, 5 months ago (2015-07-07 16:08:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-07 16:59:23 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 17:01:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/954f418961681edbaeb354d59c078b304a863a03
Cr-Commit-Position: refs/heads/master@{#337624}

Powered by Google App Engine
This is Rietveld 408576698