Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart

Issue 1226853002: Revert "dart2js: Move functionThatReturnsNull to Isolate." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 7
8 class OldEmitter implements Emitter { 8 class OldEmitter implements Emitter {
9 final Compiler compiler; 9 final Compiler compiler;
10 final CodeEmitterTask task; 10 final CodeEmitterTask task;
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 list.fixed$length = Array; 726 list.fixed$length = Array;
727 return list; 727 return list;
728 }''', 728 }''',
729 [namer.isolateName, makeConstListProperty]); 729 [namer.isolateName, makeConstListProperty]);
730 } else { 730 } else {
731 return js.comment("Output contains no constant list."); 731 return js.comment("Output contains no constant list.");
732 } 732 }
733 } 733 }
734 734
735 jsAst.Statement buildFunctionThatReturnsNull() { 735 jsAst.Statement buildFunctionThatReturnsNull() {
736 return js.statement('#.# = function() {}', 736 return js.statement('# = function() {}',
737 [namer.isolateName, 737 [backend.rti.getFunctionThatReturnsNullName]);
738 backend.rti.getFunctionThatReturnsNullName]);
739 } 738 }
740 739
741 jsAst.Expression generateFunctionThatReturnsNull() { 740 jsAst.Expression generateFunctionThatReturnsNull() {
742 return js("#.#", [namer.isolateName, 741 return js("#", [backend.rti.getFunctionThatReturnsNullName]);
743 backend.rti.getFunctionThatReturnsNullName]);
744 } 742 }
745 743
746 buildMain(jsAst.Statement invokeMain) { 744 buildMain(jsAst.Statement invokeMain) {
747 if (compiler.isMockCompilation) return js.comment("Mock compilation"); 745 if (compiler.isMockCompilation) return js.comment("Mock compilation");
748 746
749 List<jsAst.Statement> parts = <jsAst.Statement>[]; 747 List<jsAst.Statement> parts = <jsAst.Statement>[];
750 748
751 if (NativeGenerator.needsIsolateAffinityTagInitialization(backend)) { 749 if (NativeGenerator.needsIsolateAffinityTagInitialization(backend)) {
752 parts.add( 750 parts.add(
753 NativeGenerator.generateIsolateAffinityTagInitialization( 751 NativeGenerator.generateIsolateAffinityTagInitialization(
(...skipping 1250 matching lines...) Expand 10 before | Expand all | Expand 10 after
2004 for (Element element in compiler.enqueuer.codegen.newlyEnqueuedElements) { 2002 for (Element element in compiler.enqueuer.codegen.newlyEnqueuedElements) {
2005 if (element.isInstanceMember) { 2003 if (element.isInstanceMember) {
2006 cachedClassBuilders.remove(element.enclosingClass); 2004 cachedClassBuilders.remove(element.enclosingClass);
2007 2005
2008 nativeEmitter.cachedBuilders.remove(element.enclosingClass); 2006 nativeEmitter.cachedBuilders.remove(element.enclosingClass);
2009 2007
2010 } 2008 }
2011 } 2009 }
2012 } 2010 }
2013 } 2011 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698