chrome/android/java/res/layout/custom_tabs_toolbar.xml - Issue 1226833010: Clean up custom tab toolbar ellisizing and animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 1226833010: Clean up custom tab toolbar ellisizing and animation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/res/layout/custom_tabs_toolbar.xml

diff --git a/chrome/android/java/res/layout/custom_tabs_toolbar.xml b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

index 98a6c46a2abea2f831cd83833501918eb2a580fb..c5a5be870f29f849589b97469208af6b591001f9 100644

--- a/chrome/android/java/res/layout/custom_tabs_toolbar.xml

+++ b/chrome/android/java/res/layout/custom_tabs_toolbar.xml

@@ -32,7 +32,7 @@

android:layout_marginBottom="16dp"

android:layout_gravity="top"

android:maxLines="1"

- android:paddingEnd="@dimen/toolbar_edge_padding"

Yusuf 2015/07/08 18:52:13 we actually still want the padding at the end.

Ian Wen 2015/07/08 18:52:50 Done.

+ android:ellipsize="end"

android:textSize="@dimen/custom_tabs_title_text_size"

android:inputType="none"

android:visibility="gone" />

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java » ('j') | no next file with comments »