Issue 1226833009: Make `download_material_design_icons` work in a clean checkout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1226833009: Make `download_material_design_icons` work in a clean checkout. (Closed)

Created:
5 years, 5 months ago by ppi

Modified:
5 years, 5 months ago

Reviewers:
qsr, abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, jackson, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make `download_material_design_icons` work in a clean checkout. This patch makes the call to rmtree that wipes the already downloaded icons pass if the directory is not present yet. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/68ec931ee4b7c63dc2971cf635409d2bdaa5ec16

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sky/sdk/lib/download_material_design_icons	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 7 (3 generated)

ppi

Committed patchset #1 (id:1) manually as 68ec931ee4b7c63dc2971cf635409d2bdaa5ec16 (presubmit successful).

5 years, 5 months ago (2015-07-08 12:40:01 UTC) #5

Message was sent while issue was closed.

lgtm