Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1226833009: Make `download_material_design_icons` work in a clean checkout. (Closed)

Created:
5 years, 5 months ago by ppi
Modified:
5 years, 5 months ago
Reviewers:
qsr, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, jackson, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make `download_material_design_icons` work in a clean checkout. This patch makes the call to rmtree that wipes the already downloaded icons pass if the directory is not present yet. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/68ec931ee4b7c63dc2971cf635409d2bdaa5ec16

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M sky/sdk/lib/download_material_design_icons View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
ppi
Hi Ben, ptal.
5 years, 5 months ago (2015-07-08 12:20:53 UTC) #3
qsr
lgtm
5 years, 5 months ago (2015-07-08 12:37:56 UTC) #4
ppi
Committed patchset #1 (id:1) manually as 68ec931ee4b7c63dc2971cf635409d2bdaa5ec16 (presubmit successful).
5 years, 5 months ago (2015-07-08 12:40:01 UTC) #5
abarth-chromium
5 years, 5 months ago (2015-07-08 14:21:21 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698