Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1226833007: Add CaretBase::m_caretPainter, and compute caretBrowsing lazily. (Closed)

Created:
5 years, 5 months ago by jbroman
Modified:
5 years, 5 months ago
Reviewers:
pdr.
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add CaretBase::m_caretPainter, and compute caretBrowsing lazily. This avoids redundant computation of which LayoutBlock is responsible for painting the caret. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -32 lines) Patch
M Source/core/editing/Caret.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/editing/Caret.cpp View 5 chunks +6 lines, -8 lines 0 comments Download
M Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/paint/BlockPainter.cpp View 2 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jbroman
2.3 - 2.4% win instead of 3%, but substantially simpler. Good thinking. https://storage.cloud.google.com/cluster-telemetry/tasks/chromium_perf_runs/jbroman-1436246976.11/html/index.html This CL ...
5 years, 5 months ago (2015-07-07 15:20:55 UTC) #2
pdr.
On 2015/07/07 at 15:20:55, jbroman wrote: > 2.3 - 2.4% win instead of 3%, but ...
5 years, 5 months ago (2015-07-07 20:54:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226833007/1
5 years, 5 months ago (2015-07-07 20:57:35 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 21:02:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198425

Powered by Google App Engine
This is Rietveld 408576698