Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 122683002: Drop data offset in PP_EncryptedBlockInfo. (Closed)

Created:
6 years, 11 months ago by xhwang
Modified:
6 years, 11 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, binji, ihf+watch_chromium.org
Visibility:
Public.

Description

Drop data offset in PP_EncryptedBlockInfo. The data offset will be dropped from the CDM interface in a later CL. BUG=298569 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243766

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : comments addressed #

Total comments: 2

Patch Set 4 : comments addressed #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -127 lines) Patch
M content/renderer/pepper/content_decryptor_delegate.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M media/cdm/ppapi/cdm_adapter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/private/pp_content_decryptor.idl View 3 chunks +1 line, -12 lines 0 comments Download
M ppapi/api/private/ppb_content_decryptor_private.idl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ppapi/api/private/ppp_content_decryptor_private.idl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ppapi/c/private/pp_content_decryptor.h View 3 chunks +2 lines, -11 lines 0 comments Download
M ppapi/c/private/ppb_content_decryptor_private.h View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M ppapi/c/private/ppp_content_decryptor_private.h View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 3 10 chunks +79 lines, -79 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_content_decryptor_private_thunk.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
xhwang
PTAL
6 years, 11 months ago (2014-01-08 23:36:32 UTC) #1
ddorwin
LG, but I think you have to roll PPP and PPB versions too.
6 years, 11 months ago (2014-01-08 23:49:06 UTC) #2
xhwang
comments addressed
6 years, 11 months ago (2014-01-08 23:55:40 UTC) #3
xhwang
On 2014/01/08 23:49:06, ddorwin wrote: > LG, but I think you have to roll PPP ...
6 years, 11 months ago (2014-01-08 23:57:02 UTC) #4
dmichael (off chromium)
lgtm
6 years, 11 months ago (2014-01-08 23:57:14 UTC) #5
ddorwin
https://codereview.chromium.org/122683002/diff/110001/ppapi/api/private/ppb_content_decryptor_private.idl File ppapi/api/private/ppb_content_decryptor_private.idl (right): https://codereview.chromium.org/122683002/diff/110001/ppapi/api/private/ppb_content_decryptor_private.idl#newcode15 ppapi/api/private/ppb_content_decryptor_private.idl:15: M34 = 1.0 Yes, 1.0 has special meaning in ...
6 years, 11 months ago (2014-01-09 00:01:23 UTC) #6
xhwang
comments addressed
6 years, 11 months ago (2014-01-09 00:03:33 UTC) #7
xhwang
Changed to 0.10. PTAL again https://codereview.chromium.org/122683002/diff/110001/ppapi/api/private/ppb_content_decryptor_private.idl File ppapi/api/private/ppb_content_decryptor_private.idl (right): https://codereview.chromium.org/122683002/diff/110001/ppapi/api/private/ppb_content_decryptor_private.idl#newcode15 ppapi/api/private/ppb_content_decryptor_private.idl:15: M34 = 1.0 On ...
6 years, 11 months ago (2014-01-09 00:04:54 UTC) #8
ddorwin
lgtm
6 years, 11 months ago (2014-01-09 00:12:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/122683002/120011
6 years, 11 months ago (2014-01-09 00:24:59 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) app_list_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 11 months ago (2014-01-09 01:37:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/122683002/600002
6 years, 11 months ago (2014-01-09 02:22:15 UTC) #12
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 04:34:04 UTC) #13
Message was sent while issue was closed. 
Change committed as 243766

Powered by Google App Engine
This is Rietveld 408576698