Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1226813002: Enable proguarding the WebView APK. (Closed)

Created:
5 years, 5 months ago by Torne
Modified:
5 years, 5 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable proguarding the WebView APK. Proguard was disabled for WebView as the configuration was out of date. Re-enable it now the configuration has been updated. BUG=442348 Committed: https://crrev.com/edefec8e457e96dcfa7251f7fadfa24605f8a9fb Cr-Commit-Position: refs/heads/master@{#338856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M android_webview/apk/system_webview_apk_common.gypi View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Torne
Depends on https://codereview.chromium.org/1218303002/ to update the configuration; keeping it separate so it can be reverted ...
5 years, 5 months ago (2015-07-06 13:11:35 UTC) #2
sgurun-gerrit only
On 2015/07/06 13:11:35, Torne wrote: > Depends on https://codereview.chromium.org/1218303002/ to update the > configuration; keeping ...
5 years, 5 months ago (2015-07-06 17:37:59 UTC) #3
Torne
Holding off landing this until after M45 branch point after discussing with amineer@. We'll have ...
5 years, 5 months ago (2015-07-07 14:04:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226813002/1
5 years, 5 months ago (2015-07-15 14:10:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 14:34:58 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/edefec8e457e96dcfa7251f7fadfa24605f8a9fb Cr-Commit-Position: refs/heads/master@{#338856}
5 years, 5 months ago (2015-07-15 14:35:54 UTC) #8
Yusuf
5 years, 5 months ago (2015-07-15 22:41:14 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1239703003/ by yusufo@chromium.org.

The reason for reverting is: Broke release builds downstream.

crbug.com/510625.

Powered by Google App Engine
This is Rietveld 408576698