Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1226783002: Always mark entire prototype descriptor arrays. (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Always mark entire prototype descriptor arrays. BUG=chromium:506952 LOG=n Committed: https://crrev.com/8ad313545d34fdf0ffd3e4cd3d83b2cd07efa338 Cr-Commit-Position: refs/heads/master@{#29482}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M src/heap/objects-visiting-inl.h View 1 1 chunk +19 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-06 09:39:17 UTC) #2
ulan
https://codereview.chromium.org/1226783002/diff/1/src/heap/objects-visiting-inl.h File src/heap/objects-visiting-inl.h (right): https://codereview.chromium.org/1226783002/diff/1/src/heap/objects-visiting-inl.h#newcode549 src/heap/objects-visiting-inl.h:549: StaticVisitor::MarkObject(heap, descriptors); No need to mark the array explicitly ...
5 years, 5 months ago (2015-07-06 09:47:04 UTC) #3
Toon Verwaest
Addressed comment
5 years, 5 months ago (2015-07-06 10:02:01 UTC) #4
ulan
lgtm
5 years, 5 months ago (2015-07-06 10:03:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226783002/20001
5 years, 5 months ago (2015-07-06 10:06:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-06 10:33:15 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 10:33:40 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8ad313545d34fdf0ffd3e4cd3d83b2cd07efa338
Cr-Commit-Position: refs/heads/master@{#29482}

Powered by Google App Engine
This is Rietveld 408576698