Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1226773011: Remove legacy GlobalFetch runtime flag. (Closed)

Created:
5 years, 5 months ago by jeremyarcher
Modified:
5 years, 5 months ago
Reviewers:
falken, tkent, yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove legacy GlobalFetch runtime flag. (No test added: (virtual/stable/)http/serviceworker/webexposed and (virtual/stable/)webexposed still pass.) BUG=436770 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M Source/modules/fetch/Headers.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/fetch/Request.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/fetch/Response.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/modules/fetch/WindowFetch.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/fetch/WorkerFetch.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
jeremyarcher
5 years, 5 months ago (2015-07-08 06:20:10 UTC) #2
falken
Looks good. Can you add a BUG= and test mention similar to the other patches?
5 years, 5 months ago (2015-07-08 06:57:08 UTC) #3
jeremyarcher
On 2015/07/08 06:57:08, falken wrote: > Looks good. Can you add a BUG= and test ...
5 years, 5 months ago (2015-07-08 07:13:23 UTC) #5
tkent
lgtm
5 years, 5 months ago (2015-07-08 07:16:51 UTC) #6
falken
lgtm, +yhirano: FYI
5 years, 5 months ago (2015-07-08 07:23:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226773011/1
5 years, 5 months ago (2015-07-08 07:24:34 UTC) #10
yhirano
lgtm. Thanks!
5 years, 5 months ago (2015-07-08 07:26:44 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 08:33:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198480

Powered by Google App Engine
This is Rietveld 408576698