Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: tests/compiler/dart2js/mirrors_used_test.dart

Issue 1226733010: dart2js: Remove oldEmitter field in emitter-task. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/dart2js_incremental/lib/library_updater.dart ('k') | tests/compiler/dart2js/source_mapping_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/mirrors_used_test.dart
diff --git a/tests/compiler/dart2js/mirrors_used_test.dart b/tests/compiler/dart2js/mirrors_used_test.dart
index 3b2bb39012760b5a876c1ca4154405ddfdd5bb4f..53101cd5c5b2945870c38ce830db183f579b7bdc 100644
--- a/tests/compiler/dart2js/mirrors_used_test.dart
+++ b/tests/compiler/dart2js/mirrors_used_test.dart
@@ -89,10 +89,13 @@ void main() {
expectedNames = expectedNames.map(backend.namer.asName).toList();
expectedNames.addAll(nativeNames);
+ // Mirrors only work in the full emitter. We can thus be certain that the
+ // emitter is the full emitter.
+ OldEmitter fullEmitter = backend.emitter.emitter;
Set recordedNames = new Set()
- ..addAll(backend.emitter.oldEmitter.recordedMangledNames)
- ..addAll(backend.emitter.oldEmitter.mangledFieldNames.keys)
- ..addAll(backend.emitter.oldEmitter.mangledGlobalFieldNames.keys);
+ ..addAll(fullEmitter.recordedMangledNames)
+ ..addAll(fullEmitter.mangledFieldNames.keys)
+ ..addAll(fullEmitter.mangledGlobalFieldNames.keys);
Expect.setEquals(new Set.from(expectedNames), recordedNames);
for (var library in compiler.libraryLoader.libraries) {
« no previous file with comments | « pkg/dart2js_incremental/lib/library_updater.dart ('k') | tests/compiler/dart2js/source_mapping_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698