Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: src/compiler/verifier.cc

Issue 1226673005: [turbofan] Reland "Add new JSFrameSpecialization reducer." and "Perform OSR deconstruction early an… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address now -> know. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/runtime/runtime-compiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 9f886e6b7045a3f6c5ecb6316ea590456bd87d71..5f1df77736efd3081d40863f8334d11ea86aaa69 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -584,7 +584,9 @@ void Verifier::Visitor::Check(Node* node) {
break;
}
case IrOpcode::kJSForInDone: {
- CheckValueInputIs(node, 0, Type::UnsignedSmall());
+ // TODO(bmeurer): OSR breaks this invariant, although the node is not user
+ // visible, so we know it is safe (fullcodegen has an unsigned smi there).
+ // CheckValueInputIs(node, 0, Type::UnsignedSmall());
break;
}
case IrOpcode::kJSForInNext: {
@@ -592,7 +594,9 @@ void Verifier::Visitor::Check(Node* node) {
break;
}
case IrOpcode::kJSForInStep: {
- CheckValueInputIs(node, 0, Type::UnsignedSmall());
+ // TODO(bmeurer): OSR breaks this invariant, although the node is not user
+ // visible, so we know it is safe (fullcodegen has an unsigned smi there).
+ // CheckValueInputIs(node, 0, Type::UnsignedSmall());
CheckUpperIs(node, Type::UnsignedSmall());
break;
}
« no previous file with comments | « src/compiler/typer.cc ('k') | src/runtime/runtime-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698