Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: src/compiler/osr.cc

Issue 1226673005: [turbofan] Reland "Add new JSFrameSpecialization reducer." and "Perform OSR deconstruction early an… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address now -> know. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-frame-specialization.cc ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/osr.cc
diff --git a/src/compiler/osr.cc b/src/compiler/osr.cc
index fb5716a4961052f1857952150a8bd9398ed28aa5..6c4c49de7981657e86ef4c253668ea4cc16a6b7c 100644
--- a/src/compiler/osr.cc
+++ b/src/compiler/osr.cc
@@ -249,40 +249,6 @@ static void PeelOuterLoopsForOsr(Graph* graph, CommonOperatorBuilder* common,
}
-static void TransferOsrValueTypesFromLoopPhis(Zone* zone, Node* osr_loop_entry,
- Node* osr_loop) {
- // Find the index of the osr loop entry into the loop.
- int index = 0;
- for (index = 0; index < osr_loop->InputCount(); index++) {
- if (osr_loop->InputAt(index) == osr_loop_entry) break;
- }
- if (index == osr_loop->InputCount()) return;
-
- for (Node* osr_value : osr_loop_entry->uses()) {
- if (osr_value->opcode() != IrOpcode::kOsrValue) continue;
- bool unknown = true;
- for (Node* phi : osr_value->uses()) {
- if (phi->opcode() != IrOpcode::kPhi) continue;
- if (NodeProperties::GetControlInput(phi) != osr_loop) continue;
- if (phi->InputAt(index) != osr_value) continue;
- if (NodeProperties::IsTyped(phi)) {
- // Transfer the type from the phi to the OSR value itself.
- Bounds phi_bounds = NodeProperties::GetBounds(phi);
- if (unknown) {
- NodeProperties::SetBounds(osr_value, phi_bounds);
- } else {
- Bounds osr_bounds = NodeProperties::GetBounds(osr_value);
- NodeProperties::SetBounds(osr_value,
- Bounds::Both(phi_bounds, osr_bounds, zone));
- }
- unknown = false;
- }
- }
- if (unknown) NodeProperties::SetBounds(osr_value, Bounds::Unbounded(zone));
- }
-}
-
-
void OsrHelper::Deconstruct(JSGraph* jsgraph, CommonOperatorBuilder* common,
Zone* tmp_zone) {
Graph* graph = jsgraph->graph();
@@ -313,9 +279,6 @@ void OsrHelper::Deconstruct(JSGraph* jsgraph, CommonOperatorBuilder* common,
CHECK(osr_loop); // Should have found the OSR loop.
- // Transfer the types from loop phis to the OSR values which flow into them.
- TransferOsrValueTypesFromLoopPhis(graph->zone(), osr_loop_entry, osr_loop);
-
// Analyze the graph to determine how deeply nested the OSR loop is.
LoopTree* loop_tree = LoopFinder::BuildLoopTree(graph, tmp_zone);
« no previous file with comments | « src/compiler/js-frame-specialization.cc ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698