Welcome page changes for Windows 10 and over.

chrome/browser/signin/signin_promo.cc

Index: chrome/browser/signin/signin_promo.cc
diff --git a/chrome/browser/signin/signin_promo.cc b/chrome/browser/signin/signin_promo.cc
index 22663cac69961ba7af50846ef0d9915019a87844..0f0c1e0ddaec0b6c4dc0b8b0c76adcfae9c82ca2 100644
--- a/chrome/browser/signin/signin_promo.cc
+++ b/chrome/browser/signin/signin_promo.cc
@@ -38,6 +38,10 @@
 #include "net/base/url_util.h"
 #include "url/gurl.h"
 
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#endif
+
 using content::WebContents;
 
 namespace {
@@ -115,6 +119,12 @@ bool ShouldShowPromoAtStartup(Profile* profile, bool is_new_profile) {
       return false;
   }
 
+#if defined(OS_WIN)
+  // Do not show the promo on first run on Win10 and newer.
+  if (is_new_profile && base::win::GetVersion() >= base::win::VERSION_WIN10)

[gab, 2015/07/09 18:05:11]

optional: Feels this check should go first (before checking any of the prefs,
etc.).

[gab, 2015/07/09 18:05:11]

Should we add a

DCHECK_EQ(base::win::VERSION_WIN10, base::win::GetVersion())
    << "Need to revisit first run sequence on new Windows version".

here?

[grt (UTC plus 2), 2015/07/10 15:43:24]

I debated that, but decided not to since they seemed to go in order of most
general to most specific. The "on first run" part of this made it feel more
specific to me than the general "is OTR," for example.

[grt (UTC plus 2), 2015/07/10 15:43:24]

I don't think so. It will annoy a random developer using a debug build rather
than one of the deciders who will likely be using release builds to evaluate the
experience. I will make it clear to the deciders that the new behavior they've
asked for will continue on for future Windows versions until they file a bug to
change it.

+    return false;
+#endif
+
   if (HasUserSkippedPromo(profile))
     return false;