Welcome page changes for Windows 10 and over.

chrome/browser/ui/startup/startup_browser_creator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_
 #define CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/gtest_prod_util.h"
 #include "chrome/browser/prefs/session_startup_pref.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/startup/startup_tab.h"
 #include "chrome/browser/ui/startup/startup_types.h"
 #include "url/gurl.h"
 
 class Browser;
 class GURL;
+class PrefRegistrySimple;
 class PrefService;
 
 namespace base {
 class CommandLine;
 }
 
 // class containing helpers for BrowserMain to spin up a new instance and
 // initialize the profile.
 class StartupBrowserCreator {
  public:
@@ skipping 61 matching lines @@
     show_main_browser_window_ = show_main_browser_window;
   }
 
   bool show_main_browser_window() const {
     return show_main_browser_window_;
   }
 
   // For faking that no profiles have been launched yet.
   static void ClearLaunchedProfilesForTesting();
 
+#if defined(OS_WIN)

[msw, 2015/07/09 17:51:30]

Why not define this on all platforms and have an os-specific impl?

[grt (UTC plus 2), 2015/07/09 18:59:37]

No compelling reason. Done.

+  static void RegisterLocalStatePrefs(PrefRegistrySimple* registry);

[msw, 2015/07/09 17:51:30]

Why not add this to the impl class, where the prefs are used?

[grt (UTC plus 2), 2015/07/09 18:59:37]

Because I consider this .h to be the public facing portion of
browser/ui/startup. It seemed icky to me for code outside of here to care about
an implementation detail such as the impl class.

+#endif
+
  private:
   friend class CloudPrintProxyPolicyTest;
   friend class CloudPrintProxyPolicyStartupTest;
   friend class StartupBrowserCreatorImpl;
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,
                            ReadingWasRestartedAfterNormalStart);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,
                            ReadingWasRestartedAfterRestart);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, UpdateWithTwoProfiles);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, LastUsedProfileActivated);
@@ skipping 58 matching lines @@
 // Returns true if |profile| has exited uncleanly and has not been launched
 // after the unclean exit.
 bool HasPendingUncleanExit(Profile* profile);
 
 // Returns the path that contains the profile that should be loaded on process
 // startup.
 base::FilePath GetStartupProfilePath(const base::FilePath& user_data_dir,
                                      const base::CommandLine& command_line);
 
 #endif  // CHROME_BROWSER_UI_STARTUP_STARTUP_BROWSER_CREATOR_H_