Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1226633007: Sync the Presentation API interfaces with the spec again (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
mark a. foltz
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync the Presentation API interfaces with the spec again Speedily fixed in https://github.com/w3c/presentation-api/pull/144 The [SameObject] attribute does not change the generated code. BUG=460722 R=mfoltz@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/modules/presentation/DefaultSessionStartEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/NavigatorPresentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/Presentation.idl View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
5 years, 5 months ago (2015-07-07 19:26:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226633007/1
5 years, 5 months ago (2015-07-07 19:27:08 UTC) #3
mark a. foltz
lgtm
5 years, 5 months ago (2015-07-07 19:58:08 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-07 20:23:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226633007/1
5 years, 5 months ago (2015-07-07 21:04:50 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 21:08:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198426

Powered by Google App Engine
This is Rietveld 408576698