Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: build/common.gypi

Issue 1226583002: clang/win: Build chromium code without -Wno-incompatible-pointer-types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-logical-op-parentheses
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | third_party/iaccessible2/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 4aea53222a54b1bbfe15f2a4c8cccbfc19a5e24c..3bc906fcc474dd8b302837827a014fdfabac2fb1 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3087,6 +3087,11 @@
'variables': { 'clang_warning_flags': ['-Wexit-time-destructors']},
}],
['chromium_code==0', {
+ 'variables': {
+ 'clang_warning_flags': [
+ '-Wno-incompatible-pointer-types',
+ ]
+ },
'conditions': [
[ 'os_posix==1 and OS!="mac" and OS!="ios"', {
# We don't want to get warnings from third-party code,
@@ -5703,7 +5708,6 @@
'-Wno-empty-body', # http://crbug.com/504661
'-Wno-extra-tokens', # http://crbug.com/504663
'-Wno-ignored-attributes', # http://crbug.com/504695
- '-Wno-incompatible-pointer-types', # http://crbug.com/504696
'-Wno-int-to-void-pointer-cast', # http://crbug.com/504697
'-Wno-invalid-noreturn', # http://crbug.com/504698
'-Wno-logical-op-parentheses', # http://crbug.com/504699
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | third_party/iaccessible2/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698