Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/zlib/zlib.gyp

Issue 1226583002: clang/win: Build chromium code without -Wno-incompatible-pointer-types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-logical-op-parentheses
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/libwebp/libwebp.gyp ('K') | « third_party/zlib/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/zlib/zlib.gyp
diff --git a/third_party/zlib/zlib.gyp b/third_party/zlib/zlib.gyp
index bb478ceeb336fcc9281c8101ba84faf76f98d89c..42e4e9508499fc2f6da0083882edbd508265edcf 100644
--- a/third_party/zlib/zlib.gyp
+++ b/third_party/zlib/zlib.gyp
@@ -81,6 +81,11 @@
'conditions': [
['OS!="ios" and (target_arch=="ia32" or target_arch=="x64")', {
'sources' : [ 'x86.c', ],
+ 'variables': {
+ 'clang_warning_flags': [
+ '-Wno-incompatible-pointer-types',
fbarchard 2015/07/10 19:26:42 Does this option not work on arm/mips?
Nico 2015/07/10 19:28:38 It should work everywhere where we use chromium's
Sam McNally 2015/07/13 08:00:26 This is disabling a warning that is only triggered
+ ],
+ },
}],
['OS!="win"', {
'product_name': 'chrome_zlib',
« third_party/libwebp/libwebp.gyp ('K') | « third_party/zlib/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698